Skip to content

Commit eaca6e5

Browse files
Stanislav Fomichevkuba-moo
authored andcommitted
eth: bnxt: request unconditional ops lock
netdev_lock_ops conditionally grabs instance lock when queue_mgmt_ops is defined. However queue_mgmt_ops support is signaled via FW so we can sometimes boot without queue_mgmt_ops being set. This will result in bnxt running without instance lock which the driver now heavily depends on. Set request_ops_lock to true unconditionally to always request netdev instance lock. Fixes: 004b500 ("eth: bnxt: remove most dependencies on RTNL") Signed-off-by: Stanislav Fomichev <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 110eff1 commit eaca6e5

File tree

1 file changed

+1
-0
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+1
-0
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16613,6 +16613,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
1661316613
bp->rss_cap |= BNXT_RSS_CAP_MULTI_RSS_CTX;
1661416614
if (BNXT_SUPPORTS_QUEUE_API(bp))
1661516615
dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops;
16616+
dev->request_ops_lock = true;
1661616617

1661716618
rc = register_netdev(dev);
1661816619
if (rc)

0 commit comments

Comments
 (0)