Skip to content

Commit f150b63

Browse files
Zhang Changzhongdavem330
authored andcommitted
net: stmmac: selftests: fix potential memleak in stmmac_test_arpoffload()
The skb allocated by stmmac_test_get_arp_skb() hasn't been released in some error handling case, which will lead to a memory leak. Fix this up by adding kfree_skb() to release skb. Compile tested only. Fixes: 5e3fb0a ("net: stmmac: selftests: Implement the ARP Offload test") Signed-off-by: Zhang Changzhong <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent ae18dcd commit f150b63

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1654,12 +1654,16 @@ static int stmmac_test_arpoffload(struct stmmac_priv *priv)
16541654
}
16551655

16561656
ret = stmmac_set_arp_offload(priv, priv->hw, true, ip_addr);
1657-
if (ret)
1657+
if (ret) {
1658+
kfree_skb(skb);
16581659
goto cleanup;
1660+
}
16591661

16601662
ret = dev_set_promiscuity(priv->dev, 1);
1661-
if (ret)
1663+
if (ret) {
1664+
kfree_skb(skb);
16621665
goto cleanup;
1666+
}
16631667

16641668
ret = dev_direct_xmit(skb, 0);
16651669
if (ret)

0 commit comments

Comments
 (0)