Skip to content

Commit f91958c

Browse files
emuslndavem330
authored andcommitted
ionic: tame the filter no space message
Override the automatic AdminQ error message in order to capture the potential No Space message when we hit the max vlan limit, and add additional messaging to detail what filter failed. Signed-off-by: Shannon Nelson <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 8c9d956 commit f91958c

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ static int ionic_lif_filter_add(struct ionic_lif *lif,
357357
}
358358

359359
if (err != -ENOSPC)
360-
err = ionic_adminq_post_wait(lif, &ctx);
360+
err = ionic_adminq_post_wait_nomsg(lif, &ctx);
361361

362362
spin_lock_bh(&lif->rx_filters.lock);
363363

@@ -382,6 +382,19 @@ static int ionic_lif_filter_add(struct ionic_lif *lif,
382382
return 0;
383383
}
384384

385+
ionic_adminq_netdev_err_print(lif, ctx.cmd.cmd.opcode,
386+
ctx.comp.comp.status, err);
387+
switch (le16_to_cpu(ctx.cmd.rx_filter_add.match)) {
388+
case IONIC_RX_FILTER_MATCH_VLAN:
389+
netdev_info(lif->netdev, "rx_filter add failed: VLAN %d\n",
390+
ctx.cmd.rx_filter_add.vlan.vlan);
391+
break;
392+
case IONIC_RX_FILTER_MATCH_MAC:
393+
netdev_info(lif->netdev, "rx_filter add failed: ADDR %pM\n",
394+
ctx.cmd.rx_filter_add.mac.addr);
395+
break;
396+
}
397+
385398
return err;
386399
}
387400

0 commit comments

Comments
 (0)