Skip to content

Commit 0150693

Browse files
321lipengdavem330
authored andcommitted
net: hdlc: fix an code style issue about EXPORT_SYMBOL(foo)
According to the chackpatch.pl, EXPORT_SYMBOL(foo); should immediately follow its function/variable. Signed-off-by: Peng Li <[email protected]> Signed-off-by: Guangbin Huang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 68fd739 commit 0150693

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

drivers/net/wan/hdlc.c

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ netdev_tx_t hdlc_start_xmit(struct sk_buff *skb, struct net_device *dev)
7373

7474
return hdlc->xmit(skb, dev); /* call hardware driver directly */
7575
}
76+
EXPORT_SYMBOL(hdlc_start_xmit);
7677

7778
static inline void hdlc_proto_start(struct net_device *dev)
7879
{
@@ -170,6 +171,7 @@ int hdlc_open(struct net_device *dev)
170171
spin_unlock_irq(&hdlc->state_lock);
171172
return 0;
172173
}
174+
EXPORT_SYMBOL(hdlc_open);
173175

174176
/* Must be called by hardware driver when HDLC device is being closed */
175177
void hdlc_close(struct net_device *dev)
@@ -191,6 +193,7 @@ void hdlc_close(struct net_device *dev)
191193
if (hdlc->proto->close)
192194
hdlc->proto->close(dev);
193195
}
196+
EXPORT_SYMBOL(hdlc_close);
194197

195198
int hdlc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
196199
{
@@ -215,6 +218,7 @@ int hdlc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
215218
}
216219
return -EINVAL;
217220
}
221+
EXPORT_SYMBOL(hdlc_ioctl);
218222

219223
static const struct header_ops hdlc_null_ops;
220224

@@ -255,6 +259,7 @@ struct net_device *alloc_hdlcdev(void *priv)
255259
dev_to_hdlc(dev)->priv = priv;
256260
return dev;
257261
}
262+
EXPORT_SYMBOL(alloc_hdlcdev);
258263

259264
void unregister_hdlc_device(struct net_device *dev)
260265
{
@@ -263,6 +268,7 @@ void unregister_hdlc_device(struct net_device *dev)
263268
unregister_netdevice(dev);
264269
rtnl_unlock();
265270
}
271+
EXPORT_SYMBOL(unregister_hdlc_device);
266272

267273
int attach_hdlc_protocol(struct net_device *dev, struct hdlc_proto *proto,
268274
size_t size)
@@ -287,6 +293,7 @@ int attach_hdlc_protocol(struct net_device *dev, struct hdlc_proto *proto,
287293

288294
return 0;
289295
}
296+
EXPORT_SYMBOL(attach_hdlc_protocol);
290297

291298
int detach_hdlc_protocol(struct net_device *dev)
292299
{
@@ -312,6 +319,7 @@ int detach_hdlc_protocol(struct net_device *dev)
312319

313320
return 0;
314321
}
322+
EXPORT_SYMBOL(detach_hdlc_protocol);
315323

316324
void register_hdlc_protocol(struct hdlc_proto *proto)
317325
{
@@ -320,6 +328,7 @@ void register_hdlc_protocol(struct hdlc_proto *proto)
320328
first_proto = proto;
321329
rtnl_unlock();
322330
}
331+
EXPORT_SYMBOL(register_hdlc_protocol);
323332

324333
void unregister_hdlc_protocol(struct hdlc_proto *proto)
325334
{
@@ -334,22 +343,12 @@ void unregister_hdlc_protocol(struct hdlc_proto *proto)
334343
*p = proto->next;
335344
rtnl_unlock();
336345
}
346+
EXPORT_SYMBOL(unregister_hdlc_protocol);
337347

338348
MODULE_AUTHOR("Krzysztof Halasa <[email protected]>");
339349
MODULE_DESCRIPTION("HDLC support module");
340350
MODULE_LICENSE("GPL v2");
341351

342-
EXPORT_SYMBOL(hdlc_start_xmit);
343-
EXPORT_SYMBOL(hdlc_open);
344-
EXPORT_SYMBOL(hdlc_close);
345-
EXPORT_SYMBOL(hdlc_ioctl);
346-
EXPORT_SYMBOL(alloc_hdlcdev);
347-
EXPORT_SYMBOL(unregister_hdlc_device);
348-
EXPORT_SYMBOL(register_hdlc_protocol);
349-
EXPORT_SYMBOL(unregister_hdlc_protocol);
350-
EXPORT_SYMBOL(attach_hdlc_protocol);
351-
EXPORT_SYMBOL(detach_hdlc_protocol);
352-
353352
static struct packet_type hdlc_packet_type __read_mostly = {
354353
.type = cpu_to_be16(ETH_P_HDLC),
355354
.func = hdlc_rcv,

0 commit comments

Comments
 (0)