Skip to content

Commit 02281a3

Browse files
Jisheng Zhangdavem330
authored andcommitted
net: mvneta: remove duplicate *_coal assignment
The style of the rx/tx queue's *_coal member assignment is: static void foo_coal_set(...) { set the coal in hw; update queue's foo_coal member; [1] } In other place, we call foo_coal_set(pp, queue->foo_coal), so the above [1] is duplicated and could be removed. Signed-off-by: Jisheng Zhang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent e769604 commit 02281a3

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/net/ethernet/marvell/mvneta.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1555,7 +1555,6 @@ static void mvneta_rx_pkts_coal_set(struct mvneta_port *pp,
15551555
{
15561556
mvreg_write(pp, MVNETA_RXQ_THRESHOLD_REG(rxq->id),
15571557
value | MVNETA_RXQ_NON_OCCUPIED(0));
1558-
rxq->pkts_coal = value;
15591558
}
15601559

15611560
/* Set the time delay in usec before RX interrupt will be generated by
@@ -1571,7 +1570,6 @@ static void mvneta_rx_time_coal_set(struct mvneta_port *pp,
15711570
val = (clk_rate / 1000000) * value;
15721571

15731572
mvreg_write(pp, MVNETA_RXQ_TIME_COAL_REG(rxq->id), val);
1574-
rxq->time_coal = value;
15751573
}
15761574

15771575
/* Set threshold for TX_DONE pkts coalescing */
@@ -1586,8 +1584,6 @@ static void mvneta_tx_done_pkts_coal_set(struct mvneta_port *pp,
15861584
val |= MVNETA_TXQ_SENT_THRESH_MASK(value);
15871585

15881586
mvreg_write(pp, MVNETA_TXQ_SIZE_REG(txq->id), val);
1589-
1590-
txq->done_pkts_coal = value;
15911587
}
15921588

15931589
/* Handle rx descriptor fill by setting buf_cookie and buf_phys_addr */

0 commit comments

Comments
 (0)