Skip to content

Commit 1e48d54

Browse files
author
Jiri Kosina
committed
HID: plantronics: remove superfluous .probe()
Remove redundanct probe() callback, as it isn't doing anything extra that HID core wouldn't do by default. Reported-by: Benjamin Tissoires <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 1a3f83f commit 1e48d54

File tree

1 file changed

+0
-23
lines changed

1 file changed

+0
-23
lines changed

drivers/hid/hid-plantronics.c

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -36,28 +36,6 @@ static int plantronics_input_mapping(struct hid_device *hdev,
3636
return -1;
3737
}
3838

39-
static int plantronics_probe(struct hid_device *hdev,
40-
const struct hid_device_id *id)
41-
{
42-
int ret;
43-
44-
ret = hid_parse(hdev);
45-
if (ret) {
46-
hid_err(hdev, "parse failed\n");
47-
goto err;
48-
}
49-
50-
ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
51-
if (ret) {
52-
hid_err(hdev, "hw start failed\n");
53-
goto err;
54-
}
55-
56-
return 0;
57-
err:
58-
return ret;
59-
}
60-
6139
static const struct hid_device_id plantronics_devices[] = {
6240
{ HID_USB_DEVICE(USB_VENDOR_ID_PLANTRONICS, HID_ANY_ID) },
6341
{ }
@@ -68,7 +46,6 @@ static struct hid_driver plantronics_driver = {
6846
.name = "plantronics",
6947
.id_table = plantronics_devices,
7048
.input_mapping = plantronics_input_mapping,
71-
.probe = plantronics_probe,
7249
};
7350
module_hid_driver(plantronics_driver);
7451

0 commit comments

Comments
 (0)