Skip to content

Commit 4c7ccfc

Browse files
Alex Elderdavem330
authored andcommitted
net: ipa: use dev_err_probe() in ipa_clock.c
When initializing the IPA core clock and interconnects, it's possible we'll get an EPROBE_DEFER error. This isn't really an error, it's just means we need to be re-probed later. Use dev_err_probe() to report the error rather than dev_err(). This avoids polluting the log with these "error" messages. Signed-off-by: Alex Elder <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 571b1e7 commit 4c7ccfc

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

drivers/net/ipa/ipa_clock.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-License-Identifier: GPL-2.0
22

33
/* Copyright (c) 2012-2018, The Linux Foundation. All rights reserved.
4-
* Copyright (C) 2018-2020 Linaro Ltd.
4+
* Copyright (C) 2018-2021 Linaro Ltd.
55
*/
66

77
#include <linux/refcount.h>
@@ -68,8 +68,8 @@ static int ipa_interconnect_init_one(struct device *dev,
6868
if (IS_ERR(path)) {
6969
int ret = PTR_ERR(path);
7070

71-
dev_err(dev, "error %d getting %s interconnect\n", ret,
72-
data->name);
71+
dev_err_probe(dev, ret, "error getting %s interconnect\n",
72+
data->name);
7373

7474
return ret;
7575
}
@@ -281,7 +281,8 @@ ipa_clock_init(struct device *dev, const struct ipa_clock_data *data)
281281

282282
clk = clk_get(dev, "core");
283283
if (IS_ERR(clk)) {
284-
dev_err(dev, "error %ld getting core clock\n", PTR_ERR(clk));
284+
dev_err_probe(dev, PTR_ERR(clk), "error getting core clock\n");
285+
285286
return ERR_CAST(clk);
286287
}
287288

0 commit comments

Comments
 (0)