Skip to content

Commit 5a709a4

Browse files
smaeulvinodkoul
authored andcommitted
phy: rockchip-inno-usb2: Do not lock in bvalid IRQ handler
Clearing the IRQ is atomic, so there is no need to hold the mutex. Signed-off-by: Samuel Holland <[email protected]> Tested-by: Michael Riesch <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 656f7fc commit 5a709a4

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/phy/rockchip/phy-rockchip-inno-usb2.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -905,13 +905,9 @@ static irqreturn_t rockchip_usb2phy_bvalid_irq(int irq, void *data)
905905
if (!property_enabled(rphy->grf, &rport->port_cfg->bvalid_det_st))
906906
return IRQ_NONE;
907907

908-
mutex_lock(&rport->mutex);
909-
910908
/* clear bvalid detect irq pending status */
911909
property_enable(rphy->grf, &rport->port_cfg->bvalid_det_clr, true);
912910

913-
mutex_unlock(&rport->mutex);
914-
915911
rockchip_usb2phy_otg_sm_work(&rport->otg_sm_work.work);
916912

917913
return IRQ_HANDLED;

0 commit comments

Comments
 (0)