USB: don't enable remote wakeup by default

AlanStern · gregkh · commit 7aba8d014341 · 2010-05-20T13:21:37.000-07:00
This patch (as1364) avoids enabling remote wakeup by default on all
non-root-hub USB devices.  Individual drivers or userspace will have
to enable it wherever it is needed, such as for keyboards or network
interfaces.  Note: This affects only system sleep, not autosuspend.

External hubs will continue to relay wakeup requests received from
downstream through their upstream port, even when remote wakeup is not
enabled for the hub itself.  Disabling remote wakeup on a hub merely
prevents it from generating wakeup requests in response to connect,
disconnect, and overcurrent events.

Signed-off-by: Alan Stern &lt;stern@rowland.harvard.edu&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
@@ -1783,7 +1783,6 @@ int usb_new_device(struct usb_device *udev)
 		 * sysfs power/wakeup controls wakeup enabled/disabled
 		 */
 		device_init_wakeup(&udev->dev, 0);
-		device_set_wakeup_enable(&udev->dev, 1);
 	}
 
 	/* Tell the runtime-PM framework the device is active */

Original file line number	Diff line number	Diff line change
`@@ -1783,7 +1783,6 @@ int usb_new_device(struct usb_device *udev)`
`1783`	`1783`	`* sysfs power/wakeup controls wakeup enabled/disabled`
`1784`	`1784`	`*/`
`1785`	`1785`	`device_init_wakeup(&udev->dev, 0);`
`1786`		`- device_set_wakeup_enable(&udev->dev, 1);`
`1787`	`1786`	`}`
`1788`	`1787`
`1789`	`1788`	`/* Tell the runtime-PM framework the device is active */`