gro: small napi_get_frags() optim

edumazet · davem330 · commit 84b9cd633bc3 · 2013-12-06T12:51:40.000-05:00
Remove one useless conditional branch :
napi-&gt;skb is NULL, so nothing bad can happen.

Signed-off-by: Eric Dumazet &lt;edumazet@google.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/core/dev.c b/net/core/dev.c
@@ -3981,8 +3981,7 @@ struct sk_buff *napi_get_frags(struct napi_struct *napi)
 
 	if (!skb) {
 		skb = netdev_alloc_skb_ip_align(napi->dev, GRO_MAX_HEAD);
-		if (skb)
-			napi->skb = skb;
+		napi->skb = skb;
 	}
 	return skb;
 }

Original file line number	Diff line number	Diff line change
`@@ -3981,8 +3981,7 @@ struct sk_buff napi_get_frags(struct napi_struct napi)`
`3981`	`3981`
`3982`	`3982`	`if (!skb) {`
`3983`	`3983`	`skb = netdev_alloc_skb_ip_align(napi->dev, GRO_MAX_HEAD);`
`3984`		`- if (skb)`
`3985`		`- napi->skb = skb;`
	`3984`	`+ napi->skb = skb;`
`3986`	`3985`	`}`
`3987`	`3986`	`return skb;`
`3988`	`3987`	`}`