Skip to content

Commit ab7c1e1

Browse files
tiwaigregkh
authored andcommitted
firmware: Drop unused pages field from struct firmware
The struct firmware contains a page table pointer that was used only internally in the past. Since the actual page tables are referred from struct fw_priv and should be never from struct firmware, we can drop this unused field gracefully. Signed-off-by: Takashi Iwai <[email protected]> Acked-by: Luis Chamberlain <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8f3d9f3 commit ab7c1e1

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

drivers/base/firmware_loader/main.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -548,9 +548,6 @@ static void firmware_free_data(const struct firmware *fw)
548548
static void fw_set_page_data(struct fw_priv *fw_priv, struct firmware *fw)
549549
{
550550
fw->priv = fw_priv;
551-
#ifdef CONFIG_FW_LOADER_USER_HELPER
552-
fw->pages = fw_priv->pages;
553-
#endif
554551
fw->size = fw_priv->size;
555552
fw->data = fw_priv->data;
556553

include/linux/firmware.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
struct firmware {
1313
size_t size;
1414
const u8 *data;
15-
struct page **pages;
1615

1716
/* firmware loader private fields */
1817
void *priv;

0 commit comments

Comments
 (0)