Skip to content

Commit b91cf01

Browse files
inochisadlezcano
authored andcommitted
dt-bindings: timer: thead,c900-aclint-mtimer: separate mtime and mtimecmp regs
The timer registers of aclint don't follow the clint layout and can be mapped on any different offset. As sg2042 uses separated timer and mswi for its clint, it should follow the aclint spec and have separated registers. The previous patch introduced a new type of T-HEAD aclint timer which has clint timer layout. Although it has the clint timer layout, it should follow the aclint spec and uses the separated mtime and mtimecmp regs. So a ABI change is needed to make the timer fit the aclint spec. To make T-HEAD aclint timer more closer to the aclint spec, use regs-names to represent the mtimecmp register, which can avoid hack for unsupport mtime register of T-HEAD aclint timer. Also, as T-HEAD aclint only supports mtimecmp, it is unnecessary to implement the whole aclint spec. To make this binding T-HEAD specific, only add reg-name for existed register. For details, see the discussion in the last link. Signed-off-by: Inochi Amaoto <[email protected]> Fixes: 4734449 ("dt-bindings: timer: Add Sophgo sg2042 CLINT timer") Link: https://lists.infradead.org/pipermail/opensbi/2023-October/005693.html Link: https://github.com/riscv/riscv-aclint/blob/main/riscv-aclint.adoc Link: https://lore.kernel.org/all/IA1PR20MB4953F9D77FFC76A9D236922DBBB6A@IA1PR20MB4953.namprd20.prod.outlook.com/ Acked-by: Guo Ren <[email protected]> Acked-by: Conor Dooley <[email protected]> Signed-off-by: Daniel Lezcano <[email protected]> Link: https://lore.kernel.org/r/IA1PR20MB49531ED1BCC00D6B265C2D10BB86A@IA1PR20MB4953.namprd20.prod.outlook.com
1 parent da65f29 commit b91cf01

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@ properties:
1717
- const: thead,c900-aclint-mtimer
1818

1919
reg:
20-
maxItems: 1
20+
items:
21+
- description: MTIMECMP Registers
22+
23+
reg-names:
24+
items:
25+
- const: mtimecmp
2126

2227
interrupts-extended:
2328
minItems: 1
@@ -28,6 +33,7 @@ additionalProperties: false
2833
required:
2934
- compatible
3035
- reg
36+
- reg-names
3137
- interrupts-extended
3238

3339
examples:
@@ -39,5 +45,6 @@ examples:
3945
<&cpu3intc 7>,
4046
<&cpu4intc 7>;
4147
reg = <0xac000000 0x00010000>;
48+
reg-names = "mtimecmp";
4249
};
4350
...

0 commit comments

Comments
 (0)