Skip to content

Commit c5dbc2e

Browse files
committed
Merge tag '6.10-rc2-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6
Pull smb client fixes from Steve French: "Two small smb3 client fixes: - fix deadlock in umount - minor cleanup due to netfs change" * tag '6.10-rc2-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6: cifs: Don't advance the I/O iterator before terminating subrequest smb: client: fix deadlock in smb2_find_smb_tcon()
2 parents 061d1af + a88d609 commit c5dbc2e

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

fs/smb/client/smb2pdu.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4577,8 +4577,6 @@ smb2_readv_callback(struct mid_q_entry *mid)
45774577
if (rdata->subreq.start < rdata->subreq.rreq->i_size)
45784578
rdata->result = 0;
45794579
}
4580-
if (rdata->result == 0 || rdata->result == -EAGAIN)
4581-
iov_iter_advance(&rdata->subreq.io_iter, rdata->got_bytes);
45824580
rdata->credits.value = 0;
45834581
netfs_subreq_terminated(&rdata->subreq,
45844582
(rdata->result == 0 || rdata->result == -EAGAIN) ?
@@ -4789,7 +4787,6 @@ smb2_writev_callback(struct mid_q_entry *mid)
47894787
wdata->result = -ENOSPC;
47904788
else
47914789
wdata->subreq.len = written;
4792-
iov_iter_advance(&wdata->subreq.io_iter, written);
47934790
break;
47944791
case MID_REQUEST_SUBMITTED:
47954792
case MID_RETRY_NEEDED:

fs/smb/client/smb2transport.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,8 @@ smb2_find_smb_tcon(struct TCP_Server_Info *server, __u64 ses_id, __u32 tid)
216216
}
217217
tcon = smb2_find_smb_sess_tcon_unlocked(ses, tid);
218218
if (!tcon) {
219-
cifs_put_smb_ses(ses);
220219
spin_unlock(&cifs_tcp_ses_lock);
220+
cifs_put_smb_ses(ses);
221221
return NULL;
222222
}
223223
spin_unlock(&cifs_tcp_ses_lock);

0 commit comments

Comments
 (0)