net: phy: initialize rc to zero to avoid returning garbage value

Colin Ian King · davem330 · commit d16d9d2ad778 · 2016-08-13T15:51:49.000-07:00
In the case where phydev-&gt;interrupts is not PHY_INTERRUPT_ENABLED
function vsc85xx_ack_interrupt is returning an uninitialized
garbage value.  Fix this by initializing rc to zero.

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c
@@ -84,7 +84,7 @@ static int vsc85xx_config_init(struct phy_device *phydev)
 
 static int vsc85xx_ack_interrupt(struct phy_device *phydev)
 {
-       int rc;
+       int rc = 0;
 
        if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
                rc = phy_read(phydev, MII_VSC85XX_INT_STATUS);

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ static int vsc85xx_config_init(struct phy_device *phydev)`
`84`	`84`
`85`	`85`	`static int vsc85xx_ack_interrupt(struct phy_device *phydev)`
`86`	`86`	`{`
`87`		`- int rc;`
	`87`	`+ int rc = 0;`
`88`	`88`
`89`	`89`	`if (phydev->interrupts == PHY_INTERRUPT_ENABLED)`
`90`	`90`	`rc = phy_read(phydev, MII_VSC85XX_INT_STATUS);`