Skip to content

Commit dbea99d

Browse files
Wolfram Sangdavem330
authored andcommitted
net: wireless: marvell: mwifiex: usb: don't print error when allocating urb fails
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent da8794c commit dbea99d

File tree

1 file changed

+4
-15
lines changed
  • drivers/net/wireless/marvell/mwifiex

1 file changed

+4
-15
lines changed

drivers/net/wireless/marvell/mwifiex/usb.c

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -657,11 +657,8 @@ static int mwifiex_usb_tx_init(struct mwifiex_adapter *adapter)
657657
card->tx_cmd.ep = card->tx_cmd_ep;
658658

659659
card->tx_cmd.urb = usb_alloc_urb(0, GFP_KERNEL);
660-
if (!card->tx_cmd.urb) {
661-
mwifiex_dbg(adapter, ERROR,
662-
"tx_cmd.urb allocation failed\n");
660+
if (!card->tx_cmd.urb)
663661
return -ENOMEM;
664-
}
665662

666663
for (i = 0; i < MWIFIEX_TX_DATA_PORT; i++) {
667664
port = &card->port[i];
@@ -677,11 +674,8 @@ static int mwifiex_usb_tx_init(struct mwifiex_adapter *adapter)
677674
port->tx_data_list[j].ep = port->tx_data_ep;
678675
port->tx_data_list[j].urb =
679676
usb_alloc_urb(0, GFP_KERNEL);
680-
if (!port->tx_data_list[j].urb) {
681-
mwifiex_dbg(adapter, ERROR,
682-
"urb allocation failed\n");
677+
if (!port->tx_data_list[j].urb)
683678
return -ENOMEM;
684-
}
685679
}
686680
}
687681

@@ -697,10 +691,8 @@ static int mwifiex_usb_rx_init(struct mwifiex_adapter *adapter)
697691
card->rx_cmd.ep = card->rx_cmd_ep;
698692

699693
card->rx_cmd.urb = usb_alloc_urb(0, GFP_KERNEL);
700-
if (!card->rx_cmd.urb) {
701-
mwifiex_dbg(adapter, ERROR, "rx_cmd.urb allocation failed\n");
694+
if (!card->rx_cmd.urb)
702695
return -ENOMEM;
703-
}
704696

705697
card->rx_cmd.skb = dev_alloc_skb(MWIFIEX_RX_CMD_BUF_SIZE);
706698
if (!card->rx_cmd.skb)
@@ -714,11 +706,8 @@ static int mwifiex_usb_rx_init(struct mwifiex_adapter *adapter)
714706
card->rx_data_list[i].ep = card->rx_data_ep;
715707

716708
card->rx_data_list[i].urb = usb_alloc_urb(0, GFP_KERNEL);
717-
if (!card->rx_data_list[i].urb) {
718-
mwifiex_dbg(adapter, ERROR,
719-
"rx_data_list[] urb allocation failed\n");
709+
if (!card->rx_data_list[i].urb)
720710
return -1;
721-
}
722711
if (mwifiex_usb_submit_rx_urb(&card->rx_data_list[i],
723712
MWIFIEX_RX_DATA_BUF_SIZE))
724713
return -1;

0 commit comments

Comments
 (0)