Skip to content

Commit ecfa80c

Browse files
Alex ElderPaolo Abeni
authored andcommitted
net: ipa: fix an incorrect assignment
I spotted an error in a patch posted this week, unfortunately just after it got accepted. The effect of the bug is that time-based interrupt moderation is disabled. This is not technically a bug, but it is not what is intended. The problem is that a |= assignment got implemented as a simple assignment, so the previously assigned value was ignored. Fixes: edc6158 ("net: ipa: define fields for event-ring related registers") Signed-off-by: Alex Elder <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent 1c93e48 commit ecfa80c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ipa/gsi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ static void gsi_evt_ring_program(struct gsi *gsi, u32 evt_ring_id)
762762
/* Enable interrupt moderation by setting the moderation delay */
763763
reg = gsi_reg(gsi, EV_CH_E_CNTXT_8);
764764
val = reg_encode(reg, EV_MODT, GSI_EVT_RING_INT_MODT);
765-
val = reg_encode(reg, EV_MODC, 1); /* comes from channel */
765+
val |= reg_encode(reg, EV_MODC, 1); /* comes from channel */
766766
/* EV_MOD_CNT is 0 (no counter-based interrupt coalescing) */
767767
iowrite32(val, gsi->virt + reg_n_offset(reg, evt_ring_id));
768768

0 commit comments

Comments
 (0)