Skip to content

Commit f74c35b

Browse files
mantas-pvinodkoul
authored andcommitted
phy: qcom-qmp-usb: fix register offsets for ipq8074/ipq6018
Commit 2be22aa ("phy: qcom-qmp-usb: populate offsets configuration") introduced register offsets to the driver but for ipq8074/ipq6018 they do not match what was in the old style device tree. Example from old ipq6018.dtsi: <0x00078200 0x130>, /* Tx */ <0x00078400 0x200>, /* Rx */ <0x00078800 0x1f8>, /* PCS */ <0x00078600 0x044>; /* PCS misc */ which would translate to: {.., .pcs = 0x800, .pcs_misc = 0x600, .tx = 0x200, .rx = 0x400 } but was translated to: {.., .pcs = 0x600, .tx = 0x200, .rx = 0x400 } So split usb_offsets and fix USB initialization for IPQ8074 and IPQ6018. Tested only on IPQ6018 Fixes: 2be22aa ("phy: qcom-qmp-usb: populate offsets configuration") Signed-off-by: Mantas Pucka <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 6613476 commit f74c35b

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1556,6 +1556,14 @@ static const char * const qmp_phy_vreg_l[] = {
15561556
"vdda-phy", "vdda-pll",
15571557
};
15581558

1559+
static const struct qmp_usb_offsets qmp_usb_offsets_ipq8074 = {
1560+
.serdes = 0,
1561+
.pcs = 0x800,
1562+
.pcs_misc = 0x600,
1563+
.tx = 0x200,
1564+
.rx = 0x400,
1565+
};
1566+
15591567
static const struct qmp_usb_offsets qmp_usb_offsets_ipq9574 = {
15601568
.serdes = 0,
15611569
.pcs = 0x800,
@@ -1616,7 +1624,7 @@ static const struct qmp_usb_offsets qmp_usb_offsets_v7 = {
16161624
static const struct qmp_phy_cfg ipq8074_usb3phy_cfg = {
16171625
.lanes = 1,
16181626

1619-
.offsets = &qmp_usb_offsets_v3,
1627+
.offsets = &qmp_usb_offsets_ipq8074,
16201628

16211629
.serdes_tbl = ipq8074_usb3_serdes_tbl,
16221630
.serdes_tbl_num = ARRAY_SIZE(ipq8074_usb3_serdes_tbl),

0 commit comments

Comments
 (0)