Skip to content

code-server-docker fix permissions #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

code-server-docker fix permissions #11

merged 1 commit into from
Feb 10, 2020

Conversation

aptalca
Copy link
Member

@aptalca aptalca commented Feb 9, 2020

fix permissions if docker group on the host is not the default 999

@aptalca aptalca requested a review from a team February 9, 2020 16:25
@thelamer
Copy link
Member

thelamer commented Feb 9, 2020

For Taisun I shifted an existing group if conflict to an unused gid https://github.com/linuxserver/docker-taisun/blob/master/root/etc/services.d/taisun/run

Not sure if that is still relevant

@aptalca
Copy link
Member Author

aptalca commented Feb 9, 2020 •
edited
Loading

Hmm, wouldn't that get messed up if docker.sock is owned by root? Then it would try to swap root to 65500?

Not sure if it would cause any issues with other processes.

@aptalca aptalca merged commit 7b9f9c8 into linuxserver:code-server-docker Feb 10, 2020
labmonkey added a commit to labmonkey/docker-mods that referenced this pull request Mar 18, 2024
@labmonkey
# This is a combination of 37 commits.
a17115a 
# This is the 1st commit message:

Updated requirements in the Readme to mention docker dependencies

# This is the commit message linuxserver#2:

Improve the way mod behaves after restart where config directory disappears by recreating the config file (prevent unneccesary update in the api)

# This is the commit message linuxserver#3:

debug

# This is the commit message linuxserver#4:

fix

# This is the commit message linuxserver#5:

fix

# This is the commit message linuxserver#6:

fix

# This is the commit message linuxserver#7:

fix

# This is the commit message linuxserver#8:

fix

# This is the commit message linuxserver#9:

fix

# This is the commit message linuxserver#10:

Refactor whole code (same functionality)

# This is the commit message linuxserver#11:

fix

# This is the commit message linuxserver#12:

fix

# This is the commit message linuxserver#13:

fix

# This is the commit message linuxserver#14:

fix

# This is the commit message linuxserver#15:

fix

# This is the commit message linuxserver#16:

fix

# This is the commit message linuxserver#17:

fix

# This is the commit message linuxserver#18:

fix everything with pylint

# This is the commit message linuxserver#19:

fix

# This is the commit message linuxserver#20:

fix

# This is the commit message linuxserver#21:

fix

# This is the commit message linuxserver#22:

fix

# This is the commit message linuxserver#23:

fix

# This is the commit message linuxserver#24:

fix

# This is the commit message linuxserver#25:

fix

# This is the commit message linuxserver#26:

fix

# This is the commit message linuxserver#27:

fix

# This is the commit message linuxserver#28:

fix

# This is the commit message linuxserver#29:

fix

# This is the commit message linuxserver#30:

added monitor param

# This is the commit message linuxserver#31:

added support for notifications

# This is the commit message linuxserver#32:

fix

# This is the commit message linuxserver#33:

fix

# This is the commit message linuxserver#34:

fix

# This is the commit message linuxserver#35:

fix

# This is the commit message linuxserver#36:

fix

# This is the commit message linuxserver#37:

added note about defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelamer thelamer thelamer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aptalca @thelamer