Skip to content
This repository was archived by the owner on Apr 23, 2020. It is now read-only.

Commit a8d8dba

Browse files
committed
[libFuzzer] add two more variants of FuzzerDriver for convenience
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247300 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 883735e commit a8d8dba

File tree

2 files changed

+39
-20
lines changed

2 files changed

+39
-20
lines changed

lib/Fuzzer/FuzzerDriver.cpp

Lines changed: 33 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ static FlagDescription FlagDescriptions [] {
5555
static const size_t kNumFlags =
5656
sizeof(FlagDescriptions) / sizeof(FlagDescriptions[0]);
5757

58-
static std::vector<std::string> inputs;
59-
static const char *ProgName;
58+
static std::vector<std::string> *Inputs;
59+
static std::string *ProgName;
6060

6161
static void PrintHelp() {
6262
Printf("Usage: %s [-flag1=val1 [-flag2=val2 ...] ] [dir1 [dir2 ...] ]\n",
63-
ProgName);
63+
ProgName->c_str());
6464
Printf("\nFlags: (strictly in form -flag=value)\n");
6565
size_t MaxFlagLen = 0;
6666
for (size_t F = 0; F < kNumFlags; F++)
@@ -119,16 +119,17 @@ static bool ParseOneFlag(const char *Param) {
119119
}
120120

121121
// We don't use any library to minimize dependencies.
122-
static void ParseFlags(int argc, char **argv) {
122+
static void ParseFlags(const std::vector<std::string> &Args) {
123123
for (size_t F = 0; F < kNumFlags; F++) {
124124
if (FlagDescriptions[F].IntFlag)
125125
*FlagDescriptions[F].IntFlag = FlagDescriptions[F].Default;
126126
if (FlagDescriptions[F].StrFlag)
127127
*FlagDescriptions[F].StrFlag = nullptr;
128128
}
129-
for (int A = 1; A < argc; A++) {
130-
if (ParseOneFlag(argv[A])) continue;
131-
inputs.push_back(argv[A]);
129+
Inputs = new std::vector<std::string>;
130+
for (size_t A = 1; A < Args.size(); A++) {
131+
if (ParseOneFlag(Args[A].c_str())) continue;
132+
Inputs->push_back(Args[A]);
132133
}
133134
}
134135

@@ -161,15 +162,15 @@ static void WorkerThread(const std::string &Cmd, std::atomic<int> *Counter,
161162
}
162163
}
163164

164-
static int RunInMultipleProcesses(int argc, char **argv, int NumWorkers,
165-
int NumJobs) {
165+
static int RunInMultipleProcesses(const std::vector<std::string> &Args,
166+
int NumWorkers, int NumJobs) {
166167
std::atomic<int> Counter(0);
167168
std::atomic<bool> HasErrors(false);
168169
std::string Cmd;
169-
for (int i = 0; i < argc; i++) {
170-
if (FlagValue(argv[i], "jobs") || FlagValue(argv[i], "workers")) continue;
171-
Cmd += argv[i];
172-
Cmd += " ";
170+
for (auto &S : Args) {
171+
if (FlagValue(S.c_str(), "jobs") || FlagValue(S.c_str(), "workers"))
172+
continue;
173+
Cmd += S + " ";
173174
}
174175
std::vector<std::thread> V;
175176
std::thread Pulse(PulseThread);
@@ -208,10 +209,22 @@ int FuzzerDriver(int argc, char **argv, UserCallback Callback) {
208209
}
209210

210211
int FuzzerDriver(int argc, char **argv, UserSuppliedFuzzer &USF) {
211-
using namespace fuzzer;
212+
std::vector<std::string> Args(argv, argv + argc);
213+
return FuzzerDriver(Args, USF);
214+
}
212215

213-
ProgName = argv[0];
214-
ParseFlags(argc, argv);
216+
int FuzzerDriver(const std::vector<std::string> &Args, UserCallback Callback) {
217+
FuzzerRandomLibc Rand(0);
218+
SimpleUserSuppliedFuzzer SUSF(&Rand, Callback);
219+
return FuzzerDriver(Args, SUSF);
220+
}
221+
222+
int FuzzerDriver(const std::vector<std::string> &Args,
223+
UserSuppliedFuzzer &USF) {
224+
using namespace fuzzer;
225+
assert(!Args.empty());
226+
ProgName = new std::string(Args[0]);
227+
ParseFlags(Args);
215228
if (Flags.help) {
216229
PrintHelp();
217230
return 0;
@@ -224,7 +237,7 @@ int FuzzerDriver(int argc, char **argv, UserSuppliedFuzzer &USF) {
224237
}
225238

226239
if (Flags.workers > 0 && Flags.jobs > 0)
227-
return RunInMultipleProcesses(argc, argv, Flags.workers, Flags.jobs);
240+
return RunInMultipleProcesses(Args, Flags.workers, Flags.jobs);
228241

229242
Fuzzer::FuzzingOptions Options;
230243
Options.Verbosity = Flags.verbosity;
@@ -245,8 +258,8 @@ int FuzzerDriver(int argc, char **argv, UserSuppliedFuzzer &USF) {
245258
Options.TBMWidth = Flags.tbm_width;
246259
if (Flags.runs >= 0)
247260
Options.MaxNumberOfRuns = Flags.runs;
248-
if (!inputs.empty())
249-
Options.OutputCorpus = inputs[0];
261+
if (!Inputs->empty())
262+
Options.OutputCorpus = (*Inputs)[0];
250263
if (Flags.sync_command)
251264
Options.SyncCommand = Flags.sync_command;
252265
Options.SyncTimeout = Flags.sync_timeout;
@@ -282,7 +295,7 @@ int FuzzerDriver(int argc, char **argv, UserSuppliedFuzzer &USF) {
282295
}
283296

284297
F.RereadOutputCorpus();
285-
for (auto &inp : inputs)
298+
for (auto &inp : *Inputs)
286299
if (inp != Options.OutputCorpus)
287300
F.ReadDir(inp, nullptr);
288301

lib/Fuzzer/FuzzerInterface.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
#include <cstddef>
2020
#include <cstdint>
21+
#include <vector>
22+
#include <string>
2123

2224
namespace fuzzer {
2325

@@ -162,6 +164,10 @@ class UserSuppliedFuzzer {
162164
/// Runs the fuzzing with the UserSuppliedFuzzer.
163165
int FuzzerDriver(int argc, char **argv, UserSuppliedFuzzer &USF);
164166

167+
/// More C++-ish interface.
168+
int FuzzerDriver(const std::vector<std::string> &Args, UserSuppliedFuzzer &USF);
169+
int FuzzerDriver(const std::vector<std::string> &Args, UserCallback Callback);
170+
165171
} // namespace fuzzer
166172

167173
#endif // LLVM_FUZZER_INTERFACE_H

0 commit comments

Comments
 (0)