[PGO] Fix a use-after-move. NFC.

xur-llvm · xur-llvm · commit fa327aeea57f · 2016-10-19T23:31:59.000Z
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@284664 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/tools/llvm-profdata/llvm-profdata.cpp b/tools/llvm-profdata/llvm-profdata.cpp
@@ -158,13 +158,14 @@ static void loadInput(const WeightedFile &Input, WriterContext *WC) {
   }
 
   for (auto &I : *Reader) {
+    const StringRef FuncName = I.Name;
     if (Error E = WC->Writer.addRecord(std::move(I), Input.Weight)) {
       // Only show hint the first time an error occurs.
       instrprof_error IPE = InstrProfError::take(std::move(E));
       std::unique_lock<std::mutex> ErrGuard{WC->ErrLock};
       bool firstTime = WC->WriterErrorCodes.insert(IPE).second;
       handleMergeWriterError(make_error<InstrProfError>(IPE), Input.Filename,
-                             I.Name, firstTime);
+                             FuncName, firstTime);
     }
   }
   if (Reader->hasError())

Original file line number	Diff line number	Diff line change
`@@ -158,13 +158,14 @@ static void loadInput(const WeightedFile &Input, WriterContext *WC) {`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`for (auto &I : *Reader) {`
	`161`	`+ const StringRef FuncName = I.Name;`
`161`	`162`	`if (Error E = WC->Writer.addRecord(std::move(I), Input.Weight)) {`
`162`	`163`	`// Only show hint the first time an error occurs.`
`163`	`164`	`instrprof_error IPE = InstrProfError::take(std::move(E));`
`164`	`165`	`std::unique_lock<std::mutex> ErrGuard{WC->ErrLock};`
`165`	`166`	`bool firstTime = WC->WriterErrorCodes.insert(IPE).second;`
`166`	`167`	`handleMergeWriterError(make_error<InstrProfError>(IPE), Input.Filename,`
`167`		`- I.Name, firstTime);`
	`168`	`+ FuncName, firstTime);`
`168`	`169`	`}`
`169`	`170`	`}`
`170`	`171`	`if (Reader->hasError())`