Skip to content

Commit 8d6def6

Browse files
fhahnAlexisPerry
authored andcommitted
[LV] Make create-induction-resume.ll more robust by adding store.
Without the store, the vector loop body is empty. Add a store to avoid that, while not impacting the induction resume values that are created.
1 parent 11204a1 commit 8d6def6

File tree

1 file changed

+28
-6
lines changed

1 file changed

+28
-6
lines changed

llvm/test/Transforms/LoopVectorize/create-induction-resume.ll

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2-
; RUN: opt -S -passes=loop-vectorize < %s | FileCheck %s
2+
; RUN: opt -S -passes=loop-vectorize -force-vector-width=4 < %s | FileCheck %s
33

44
; This is a regression test. Without the fix it crashes on SSAUpdater due to
55
; LoopVectroizer created a phi node placeholder without incoming values but
66
; SSAUpdater expects that phi node is completely filled.
77

88
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128-ni:1-p2:32:8:8:32-ni:2"
9-
define void @test(i32 %arg, i32 %L1.limit, i32 %L2.switch, i1 %c) {
9+
define void @test(i32 %arg, i32 %L1.limit, i32 %L2.switch, i1 %c, ptr %dst) {
1010
; CHECK-LABEL: @test(
1111
; CHECK-NEXT: L1.preheader:
1212
; CHECK-NEXT: [[TMP0:%.*]] = sub i32 -1, [[ARG:%.*]]
@@ -36,8 +36,8 @@ define void @test(i32 %arg, i32 %L1.limit, i32 %L2.switch, i1 %c) {
3636
; CHECK-NEXT: br label [[L2_HEADER_BACKEDGE:%.*]]
3737
; CHECK: L2.header:
3838
; CHECK-NEXT: switch i32 [[L2_SWITCH:%.*]], label [[L2_HEADER_BACKEDGE]] [
39-
; CHECK-NEXT: i32 8, label [[L2_EXIT:%.*]]
40-
; CHECK-NEXT: i32 20, label [[L2_INNER_HEADER_PREHEADER:%.*]]
39+
; CHECK-NEXT: i32 8, label [[L2_EXIT:%.*]]
40+
; CHECK-NEXT: i32 20, label [[L2_INNER_HEADER_PREHEADER:%.*]]
4141
; CHECK-NEXT: ]
4242
; CHECK: L2.header.backedge:
4343
; CHECK-NEXT: br label [[L2_HEADER]]
@@ -46,12 +46,30 @@ define void @test(i32 %arg, i32 %L1.limit, i32 %L2.switch, i1 %c) {
4646
; CHECK: vector.ph:
4747
; CHECK-NEXT: [[TMP3:%.*]] = mul i32 12, [[INDUCTION_IV_LCSSA1]]
4848
; CHECK-NEXT: [[IND_END:%.*]] = add i32 1, [[TMP3]]
49+
; CHECK-NEXT: [[DOTSPLATINSERT:%.*]] = insertelement <4 x i32> poison, i32 [[INDUCTION_IV_LCSSA1]], i64 0
50+
; CHECK-NEXT: [[DOTSPLAT:%.*]] = shufflevector <4 x i32> [[DOTSPLATINSERT]], <4 x i32> poison, <4 x i32> zeroinitializer
51+
; CHECK-NEXT: [[TMP4:%.*]] = mul <4 x i32> <i32 0, i32 1, i32 2, i32 3>, [[DOTSPLAT]]
52+
; CHECK-NEXT: [[INDUCTION:%.*]] = add <4 x i32> <i32 1, i32 1, i32 1, i32 1>, [[TMP4]]
53+
; CHECK-NEXT: [[TMP5:%.*]] = mul i32 [[INDUCTION_IV_LCSSA1]], 4
54+
; CHECK-NEXT: [[DOTSPLATINSERT3:%.*]] = insertelement <4 x i32> poison, i32 [[TMP5]], i64 0
55+
; CHECK-NEXT: [[DOTSPLAT4:%.*]] = shufflevector <4 x i32> [[DOTSPLATINSERT3]], <4 x i32> poison, <4 x i32> zeroinitializer
56+
; CHECK-NEXT: [[BROADCAST_SPLATINSERT:%.*]] = insertelement <4 x i32> poison, i32 [[L1_EXIT_VAL]], i64 0
57+
; CHECK-NEXT: [[BROADCAST_SPLAT:%.*]] = shufflevector <4 x i32> [[BROADCAST_SPLATINSERT]], <4 x i32> poison, <4 x i32> zeroinitializer
4958
; CHECK-NEXT: br label [[VECTOR_BODY:%.*]]
5059
; CHECK: vector.body:
5160
; CHECK-NEXT: [[INDEX:%.*]] = phi i64 [ 0, [[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], [[VECTOR_BODY]] ]
61+
; CHECK-NEXT: [[VEC_IND:%.*]] = phi <4 x i32> [ [[INDUCTION]], [[VECTOR_PH]] ], [ [[VEC_IND_NEXT:%.*]], [[VECTOR_BODY]] ]
62+
; CHECK-NEXT: [[OFFSET_IDX:%.*]] = add i64 1, [[INDEX]]
63+
; CHECK-NEXT: [[TMP6:%.*]] = add i64 [[OFFSET_IDX]], 0
64+
; CHECK-NEXT: [[TMP7:%.*]] = sub <4 x i32> [[VEC_IND]], [[BROADCAST_SPLAT]]
65+
; CHECK-NEXT: [[TMP8:%.*]] = sext <4 x i32> [[TMP7]] to <4 x i64>
66+
; CHECK-NEXT: [[TMP9:%.*]] = getelementptr inbounds i64, ptr [[DST:%.*]], i64 [[TMP6]]
67+
; CHECK-NEXT: [[TMP10:%.*]] = getelementptr inbounds i64, ptr [[TMP9]], i32 0
68+
; CHECK-NEXT: store <4 x i64> [[TMP8]], ptr [[TMP10]], align 8
5269
; CHECK-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 4
53-
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i64 [[INDEX_NEXT]], 12
54-
; CHECK-NEXT: br i1 [[TMP4]], label [[MIDDLE_BLOCK:%.*]], label [[VECTOR_BODY]], !llvm.loop [[LOOP0:![0-9]+]]
70+
; CHECK-NEXT: [[VEC_IND_NEXT]] = add <4 x i32> [[VEC_IND]], [[DOTSPLAT4]]
71+
; CHECK-NEXT: [[TMP11:%.*]] = icmp eq i64 [[INDEX_NEXT]], 12
72+
; CHECK-NEXT: br i1 [[TMP11]], label [[MIDDLE_BLOCK:%.*]], label [[VECTOR_BODY]], !llvm.loop [[LOOP0:![0-9]+]]
5573
; CHECK: middle.block:
5674
; CHECK-NEXT: br i1 true, label [[L2_HEADER_LOOPEXIT:%.*]], label [[SCALAR_PH]]
5775
; CHECK: scalar.ph:
@@ -63,6 +81,8 @@ define void @test(i32 %arg, i32 %L1.limit, i32 %L2.switch, i1 %c) {
6381
; CHECK-NEXT: [[L2_IV:%.*]] = phi i64 [ [[L2_IV_NEXT:%.*]], [[L2_INNER_HEADER]] ], [ [[BC_RESUME_VAL2]], [[SCALAR_PH]] ]
6482
; CHECK-NEXT: [[L2_ACCUM_NEXT]] = sub i32 [[L2_ACCUM]], [[L1_EXIT_VAL]]
6583
; CHECK-NEXT: [[L2_DUMMY_BUT_NEED_IT:%.*]] = sext i32 [[L2_ACCUM_NEXT]] to i64
84+
; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds i64, ptr [[DST]], i64 [[L2_IV]]
85+
; CHECK-NEXT: store i64 [[L2_DUMMY_BUT_NEED_IT]], ptr [[GEP]], align 8
6686
; CHECK-NEXT: [[L2_IV_NEXT]] = add nuw nsw i64 [[L2_IV]], 1
6787
; CHECK-NEXT: [[L2_EXIT_COND:%.*]] = icmp ugt i64 [[L2_IV]], 11
6888
; CHECK-NEXT: br i1 [[L2_EXIT_COND]], label [[L2_HEADER_LOOPEXIT]], label [[L2_INNER_HEADER]], !llvm.loop [[LOOP3:![0-9]+]]
@@ -101,6 +121,8 @@ L2.Inner.header: ; preds = %L2.Inner.header, %L
101121
%L2.iv = phi i64 [ %L2.iv.next, %L2.Inner.header ], [ 1, %L2.header ]
102122
%L2.accum.next = sub i32 %L2.accum, %L1.exit.val
103123
%L2.dummy.but.need.it = sext i32 %L2.accum.next to i64
124+
%gep = getelementptr inbounds i64 , ptr %dst, i64 %L2.iv
125+
store i64 %L2.dummy.but.need.it, ptr %gep
104126
%L2.iv.next = add nuw nsw i64 %L2.iv, 1
105127
%L2.exit_cond = icmp ugt i64 %L2.iv, 11
106128
br i1 %L2.exit_cond, label %L2.header, label %L2.Inner.header

0 commit comments

Comments
 (0)