Document Target and TargetData #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
commented
Jan 9, 2017
| /// | ||
| /// - returns: The size of the type in bytes. | ||
| public func sizeOfTypeInBits(_ type: IRType) -> Int { | ||
| return Int(LLVMSizeOfTypeInBits(llvm, type.asLLVM())) |
There was a problem hiding this comment.
"Bits, bytes, what's the difference"
- LLVM
There was a problem hiding this comment.
If LLVM's is named wrong, then maybe we should rename this method...
There was a problem hiding this comment.
Trouble is, I'm not entirely sure which is actually correct.
There was a problem hiding this comment.
print(module.dataLayout.sizeOfTypeInBits(IntType.int64))
// 64
There was a problem hiding this comment.
Sorry, forgot to update the footer text.
CodaFi
force-pushed
the
target-acquired
branch
from
cfcda96 to
84ed41c
Compare
harlanhaskins
requested changes
Jan 9, 2017
| } | ||
|
|
||
| /// The model generated code should follow. This enables particular styles of |
There was a problem hiding this comment.
I think this could benefit from 'that' or 'which'
CodaFi
force-pushed
the
target-acquired
branch
from
84ed41c to
2a27103
Compare
CodaFi
force-pushed
the
target-acquired
branch
from
2a27103 to
3b6ac21
Compare
harlanhaskins
approved these changes
Jan 9, 2017
|
I'll merge it once you run jazzy again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency here between the name of
LLVMSizeOfTypeInBitsand the LLVM documentation.