Skip to content

Commit 0169a45

Browse files
committed
Use array_pod_sort. NFC.
llvm-svn: 251023
1 parent 9bccaa1 commit 0169a45

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

llvm/lib/MC/StringTableBuilder.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,25 @@
99

1010
#include "llvm/MC/StringTableBuilder.h"
1111
#include "llvm/ADT/SmallVector.h"
12+
#include "llvm/ADT/STLExtras.h"
1213
#include "llvm/Support/COFF.h"
1314
#include "llvm/Support/Endian.h"
1415

1516
using namespace llvm;
1617

17-
static bool compareBySuffix(StringRef a, StringRef b) {
18+
static int compareBySuffix(const StringRef *AP, const StringRef *BP) {
19+
StringRef a = *AP;
20+
StringRef b = *BP;
1821
size_t sizeA = a.size();
1922
size_t sizeB = b.size();
2023
size_t len = std::min(sizeA, sizeB);
2124
for (size_t i = 0; i < len; ++i) {
2225
char ca = a[sizeA - i - 1];
2326
char cb = b[sizeB - i - 1];
2427
if (ca != cb)
25-
return ca > cb;
28+
return cb - ca;
2629
}
27-
return sizeA > sizeB;
30+
return sizeB - sizeA;
2831
}
2932

3033
void StringTableBuilder::finalize(Kind kind) {
@@ -34,7 +37,7 @@ void StringTableBuilder::finalize(Kind kind) {
3437
for (auto i = StringIndexMap.begin(), e = StringIndexMap.end(); i != e; ++i)
3538
Strings.push_back(i->getKey());
3639

37-
std::sort(Strings.begin(), Strings.end(), compareBySuffix);
40+
array_pod_sort(Strings.begin(), Strings.end(), compareBySuffix);
3841

3942
switch (kind) {
4043
case ELF:

0 commit comments

Comments
 (0)