Skip to content

Commit 01c742b

Browse files
bharadwajyBharadwaj Yadavalli
authored andcommitted
Incorporate additional PR feedback.
1 parent b73372b commit 01c742b

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

clang/lib/Driver/ToolChains/HLSL.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@
1212
#include "clang/Driver/DriverDiagnostic.h"
1313
#include "clang/Driver/Job.h"
1414
#include "llvm/ADT/StringSwitch.h"
15-
#include "llvm/Support/ErrorHandling.h"
1615
#include "llvm/TargetParser/Triple.h"
1716
#include <optional>
18-
#include <string>
1917

2018
using namespace clang::driver;
2119
using namespace clang::driver::tools;
@@ -39,9 +37,8 @@ bool isLegalShaderModel(Triple &T) {
3937
return false;
4038

4139
// DXIL Version should be set as SubArch
42-
if (T.getSubArch() == Triple::NoSubArch) {
40+
if (T.getSubArch() == Triple::NoSubArch)
4341
return false;
44-
}
4542

4643
auto Kind = T.getEnvironment();
4744

@@ -140,8 +137,7 @@ std::optional<std::string> tryParseProfile(StringRef Profile) {
140137
case 8:
141138
SubArch = llvm::Triple::DXILSubArch_v1_8;
142139
break;
143-
}
144-
if (SubArch == llvm::Triple::NoSubArch) {
140+
default :
145141
// No DXIL Version corresponding to specified Shader Model version found
146142
return std::nullopt;
147143
}

0 commit comments

Comments
 (0)