fix TryToFixInvalidVariablyModifiedType to reject negative array sizes

llvm-svn: 63557

Author: nunoplopes

clang/lib/Sema/SemaDecl.cpp

@@ -3114,9 +3114,10 @@ static QualType TryToFixInvalidVariablyModifiedType(QualType T,
 
   assert(EvalResult.Val.isInt() && "Size expressions must be integers!");
   llvm::APSInt &Res = EvalResult.Val.getInt();
-
-  return Context.getConstantArrayType(VLATy->getElementType(),
-                                      Res, ArrayType::Normal, 0);
+  if (Res >= llvm::APSInt(Res.getBitWidth(), Res.isUnsigned()))
+    return Context.getConstantArrayType(VLATy->getElementType(),
+                                        Res, ArrayType::Normal, 0);
+  return QualType();
 }
 
 bool Sema::VerifyBitField(SourceLocation FieldLoc, IdentifierInfo *FieldName, 

clang/test/Sema/struct-decl.c

@@ -7,4 +7,5 @@ struct bar {
 
 struct foo {
 	char name[(int)&((struct bar *)0)->n];
+	char name2[(int)&((struct bar *)0)->n - 1]; //expected-error{{fields must have a constant size}}
 };