[AST] Simplify string comparisons (NFC) (#141189)

kazutakahirata · web-flow · commit 02ed6d82f66f · 2025-05-22T22:36:36.000-07:00
diff --git a/clang/unittests/AST/DeclTest.cpp b/clang/unittests/AST/DeclTest.cpp
@@ -104,8 +104,9 @@ TEST(Decl, AsmLabelAttr) {
     MC->mangleName(DeclG, OS_G);
   }
 
-  ASSERT_TRUE(0 == MangleF.compare("\x01" "foo"));
-  ASSERT_TRUE(0 == MangleG.compare("goo"));
+  ASSERT_EQ(MangleF, "\x01"
+                     "foo");
+  ASSERT_EQ(MangleG, "goo");
 }
 
 TEST(Decl, MangleDependentSizedArray) {
@@ -138,8 +139,8 @@ TEST(Decl, MangleDependentSizedArray) {
   MC->mangleCanonicalTypeName(DeclA->getType(), OS_A);
   MC->mangleCanonicalTypeName(DeclB->getType(), OS_B);
 
-  ASSERT_TRUE(0 == MangleA.compare("_ZTSA_i"));
-  ASSERT_TRUE(0 == MangleB.compare("_ZTSAT0__T_"));
+  ASSERT_EQ(MangleA, "_ZTSA_i");
+  ASSERT_EQ(MangleB, "_ZTSAT0__T_");
 }
 
 TEST(Decl, ConceptDecl) {

Original file line number	Diff line number	Diff line change
`@@ -104,8 +104,9 @@ TEST(Decl, AsmLabelAttr) {`
`104`	`104`	`MC->mangleName(DeclG, OS_G);`
`105`	`105`	`}`
`106`	`106`
`107`		`- ASSERT_TRUE(0 == MangleF.compare("\x01" "foo"));`
`108`		`- ASSERT_TRUE(0 == MangleG.compare("goo"));`
	`107`	`+ ASSERT_EQ(MangleF, "\x01"`
	`108`	`+ "foo");`
	`109`	`+ ASSERT_EQ(MangleG, "goo");`
`109`	`110`	`}`
`110`	`111`
`111`	`112`	`TEST(Decl, MangleDependentSizedArray) {`
`@@ -138,8 +139,8 @@ TEST(Decl, MangleDependentSizedArray) {`
`138`	`139`	`MC->mangleCanonicalTypeName(DeclA->getType(), OS_A);`
`139`	`140`	`MC->mangleCanonicalTypeName(DeclB->getType(), OS_B);`
`140`	`141`
`141`		`- ASSERT_TRUE(0 == MangleA.compare("_ZTSA_i"));`
`142`		`- ASSERT_TRUE(0 == MangleB.compare("_ZTSAT0__T_"));`
	`142`	`+ ASSERT_EQ(MangleA, "_ZTSA_i");`
	`143`	`+ ASSERT_EQ(MangleB, "_ZTSAT0__T_");`
`143`	`144`	`}`
`144`	`145`
`145`	`146`	`TEST(Decl, ConceptDecl) {`