Skip to content

Commit 03439a8

Browse files
committed
Silence some MSVC warnings.
Summary: Just `assert("string" && false)` instead of `assert("string" == NULL)`. This avoid errors like [...]\Core\SourceManager.cpp(647): warning C4130: '==' : logical operation on address of string constant Reviewers: zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D12388 llvm-svn: 246123
1 parent b39e44b commit 03439a8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lldb/source/Core/SourceManager.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -644,14 +644,14 @@ SourceManager::File::CalculateLineOffsets (uint32_t line)
644644
else
645645
{
646646
// Some lines have been populated, start where we last left off
647-
assert("Not implemented yet" == NULL);
647+
assert("Not implemented yet" && false);
648648
}
649649

650650
}
651651
else
652652
{
653653
// Calculate all line offsets up to "line"
654-
assert("Not implemented yet" == NULL);
654+
assert("Not implemented yet" && false);
655655
}
656656
return false;
657657
}

0 commit comments

Comments
 (0)