Print more descriptive error message when trying to link a global with appending linkage (#69613)

arrowd · web-flow · commit 0356d0cfdc5c · 2024-04-03T12:26:12.000+01:00
This is a proper fix for #40308
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -2927,7 +2927,7 @@ bool AsmPrinter::emitSpecialLLVMGlobal(const GlobalVariable *GV) {
     return true;
   }
 
-  report_fatal_error("unknown special variable");
+  report_fatal_error("unknown special variable with appending linkage");
 }
 
 /// EmitLLVMUsedList - For targets that define a MAI::UsedDirective, mark each
diff --git a/llvm/test/CodeGen/X86/AppendingLinkage.ll b/llvm/test/CodeGen/X86/AppendingLinkage.ll
@@ -1,4 +1,4 @@
 ; RUN: not --crash llc < %s -mtriple=i686-- 2>&1 | FileCheck %s
 
-; CHECK: unknown special variable
+; CHECK: unknown special variable with appending linkage
 @foo = appending constant [1 x i32 ]zeroinitializer

Original file line number	Diff line number	Diff line change
`@@ -2927,7 +2927,7 @@ bool AsmPrinter::emitSpecialLLVMGlobal(const GlobalVariable *GV) {`
`2927`	`2927`	`return true;`
`2928`	`2928`	`}`
`2929`	`2929`
`2930`		`- report_fatal_error("unknown special variable");`
	`2930`	`+ report_fatal_error("unknown special variable with appending linkage");`
`2931`	`2931`	`}`
`2932`	`2932`
`2933`	`2933`	`/// EmitLLVMUsedList - For targets that define a MAI::UsedDirective, mark each`