[clang][Sema][NFC] remove unreachable return statement (#100642)

mikerice1969 · web-flow · commit 04133283a9f5 · 2024-07-26T09:35:11.000-07:00
The switch now returns in every case so the end return is unreachable.
diff --git a/clang/lib/Sema/SemaPPC.cpp b/clang/lib/Sema/SemaPPC.cpp
@@ -93,7 +93,6 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI,
                                           unsigned BuiltinID,
                                           CallExpr *TheCall) {
   ASTContext &Context = getASTContext();
-  unsigned i = 0, l = 0, u = 0;
   bool IsTarget64Bit = TI.getTypeWidth(TI.getIntPtrType()) == 64;
   llvm::APSInt Result;
 
@@ -248,7 +247,7 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI,
     return BuiltinPPCMMACall(TheCall, BuiltinID, Types);
 #include "clang/Basic/BuiltinsPPC.def"
   }
-  return SemaRef.BuiltinConstantArgRange(TheCall, i, l, u);
+  llvm_unreachable("must return from switch");
 }
 
 // Check if the given type is a non-pointer PPC MMA type. This function is used

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,6 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI,`
`93`	`93`	`unsigned BuiltinID,`
`94`	`94`	`CallExpr *TheCall) {`
`95`	`95`	`ASTContext &Context = getASTContext();`
`96`		`- unsigned i = 0, l = 0, u = 0;`
`97`	`96`	`bool IsTarget64Bit = TI.getTypeWidth(TI.getIntPtrType()) == 64;`
`98`	`97`	`llvm::APSInt Result;`
`99`	`98`
`@@ -248,7 +247,7 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI,`
`248`	`247`	`return BuiltinPPCMMACall(TheCall, BuiltinID, Types);`
`249`	`248`	`#include "clang/Basic/BuiltinsPPC.def"`
`250`	`249`	`}`
`251`		`- return SemaRef.BuiltinConstantArgRange(TheCall, i, l, u);`
	`250`	`+ llvm_unreachable("must return from switch");`
`252`	`251`	`}`
`253`	`252`
`254`	`253`	`// Check if the given type is a non-pointer PPC MMA type. This function is used`