Skip to content

Commit 058ab9f

Browse files
committed
[AMDGPU][True16][MC] Copy True16Predicate from pseudo to real in VOP1
This is a necessary change for consistency and an upcoming patch. Cleanup an affected extra whitespace and wrong CHECK prefix in v_swap_b16.
1 parent 67c4345 commit 058ab9f

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

llvm/lib/Target/AMDGPU/VOP1Instructions.td

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ class VOP1_Real <VOP1_Pseudo ps, int EncodingFamily, string real_name = ps.Mnemo
7676
// copy relevant pseudo op flags
7777
let SubtargetPredicate = ps.SubtargetPredicate;
7878
let OtherPredicates = ps.OtherPredicates;
79+
let True16Predicate = ps.True16Predicate;
7980
let AsmMatchConverter = ps.AsmMatchConverter;
8081
let AsmVariantName = ps.AsmVariantName;
8182
let Constraints = ps.Constraints;
@@ -735,7 +736,7 @@ def VOP_SWAP_I16 : VOPProfile_True16<VOP_I16_I16> {
735736
VOPSrcEncodedDstOperand_t16Lo128:$vdst1);
736737
let Ins32 = (ins VOPSrcEncodedDstOperand_t16Lo128:$src0,
737738
VOPDstOperand_t16Lo128:$src1);
738-
let Asm32 = " $vdst, $src0";
739+
let Asm32 = "$vdst, $src0";
739740
}
740741

741742
let SubtargetPredicate = isGFX11Plus in {

llvm/test/MC/AMDGPU/gfx12_asm_vop1.s

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3555,13 +3555,13 @@ v_sqrt_f64 v[254:255], 0xaf123456
35553555
// GFX12: v_sqrt_f64_e32 v[254:255], 0xaf123456 ; encoding: [0xff,0x68,0xfc,0x7f,0x56,0x34,0x12,0xaf]
35563556

35573557
v_swap_b16 v5.l, v1.h
3558-
// GFX12: v_swap_b16 v5.l, v1.h ; encoding: [0x81,0xcd,0x0a,0x7e]
3558+
// GFX12: v_swap_b16 v5.l, v1.h ; encoding: [0x81,0xcd,0x0a,0x7e]
35593559

35603560
v_swap_b16 v5.h, v1.l
3561-
// GFX12: v_swap_b16 v5.h, v1.l ; encoding: [0x01,0xcd,0x0a,0x7f]
3561+
// GFX12: v_swap_b16 v5.h, v1.l ; encoding: [0x01,0xcd,0x0a,0x7f]
35623562

35633563
v_swap_b16 v127.l, v127.l
3564-
// GFX12: v_swap_b16 v127.l, v127.l ; encoding: [0x7f,0xcd,0xfe,0x7e]
3564+
// GFX12: v_swap_b16 v127.l, v127.l ; encoding: [0x7f,0xcd,0xfe,0x7e]
35653565

35663566
v_swap_b32 v5, v1
35673567
// GFX12: v_swap_b32 v5, v1 ; encoding: [0x01,0xcb,0x0a,0x7e]

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop1.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3499,10 +3499,10 @@
34993499
# GFX11: v_sqrt_f64_e32 v[254:255], 0xaf123456 ; encoding: [0xff,0x68,0xfc,0x7f,0x56,0x34,0x12,0xaf]
35003500
0xff,0x68,0xfc,0x7f,0x56,0x34,0x12,0xaf
35013501

3502-
# GFX11-TRUE16: v_swap_b16 v5.l, v1.h ; encoding: [0x81,0xcd,0x0a,0x7e]
3502+
# GFX11-REAL16: v_swap_b16 v5.l, v1.h ; encoding: [0x81,0xcd,0x0a,0x7e]
35033503
0x81,0xcd,0x0a,0x7e
35043504

3505-
# GFX11-TRUE16: v_swap_b16 v5.h, v1.l ; encoding: [0x01,0xcd,0x0a,0x7f]
3505+
# GFX11-REAL16: v_swap_b16 v5.h, v1.l ; encoding: [0x01,0xcd,0x0a,0x7f]
35063506
0x01,0xcd,0x0a,0x7f
35073507

35083508
# GFX11: v_swap_b32 v5, v1 ; encoding: [0x01,0xcb,0x0a,0x7e]

0 commit comments

Comments
 (0)