Skip to content

Commit 059722d

Browse files
committed
Revert "[RISCV] Default to MicroOpBufferSize = 1 for scheduling purposes (#126608)" and follow up commit.
This reverts commit 9cc8442. This reverts commit 859c871. A performance regression was reported on the original review. There appears to have been an unexpected interaction here. Reverting during investigation.
1 parent 4ee173a commit 059722d

File tree

405 files changed

+29155
-27979
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

405 files changed

+29155
-27979
lines changed

llvm/lib/Target/RISCV/RISCV.td

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ include "RISCVMacroFusion.td"
4646
// RISC-V Scheduling Models
4747
//===----------------------------------------------------------------------===//
4848

49-
include "RISCVSchedGeneric.td"
5049
include "RISCVSchedMIPSP8700.td"
5150
include "RISCVSchedRocket.td"
5251
include "RISCVSchedSiFive7.td"

llvm/lib/Target/RISCV/RISCVProcessors.td

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,20 +89,20 @@ class RISCVTuneProcessorModel<string n,
8989
defvar GenericTuneFeatures = [TuneOptimizedNF2SegmentLoadStore];
9090

9191
def GENERIC_RV32 : RISCVProcessorModel<"generic-rv32",
92-
GenericModel,
92+
NoSchedModel,
9393
[Feature32Bit,
9494
FeatureStdExtI],
9595
GenericTuneFeatures>,
9696
GenericTuneInfo;
9797
def GENERIC_RV64 : RISCVProcessorModel<"generic-rv64",
98-
GenericModel,
98+
NoSchedModel,
9999
[Feature64Bit,
100100
FeatureStdExtI],
101101
GenericTuneFeatures>,
102102
GenericTuneInfo;
103103
// Support generic for compatibility with other targets. The triple will be used
104104
// to change to the appropriate rv32/rv64 version.
105-
def GENERIC : RISCVTuneProcessorModel<"generic", GenericModel>, GenericTuneInfo;
105+
def GENERIC : RISCVTuneProcessorModel<"generic", NoSchedModel>, GenericTuneInfo;
106106

107107
def MIPS_P8700 : RISCVProcessorModel<"mips-p8700",
108108
MIPSP8700Model,
@@ -496,7 +496,7 @@ def TENSTORRENT_ASCALON_D8 : RISCVProcessorModel<"tt-ascalon-d8",
496496
TunePostRAScheduler]>;
497497

498498
def VENTANA_VEYRON_V1 : RISCVProcessorModel<"veyron-v1",
499-
GenericModel,
499+
NoSchedModel,
500500
[Feature64Bit,
501501
FeatureStdExtI,
502502
FeatureStdExtZifencei,
@@ -556,7 +556,7 @@ def XIANGSHAN_NANHU : RISCVProcessorModel<"xiangshan-nanhu",
556556
TuneShiftedZExtWFusion]>;
557557

558558
def SPACEMIT_X60 : RISCVProcessorModel<"spacemit-x60",
559-
GenericModel,
559+
NoSchedModel,
560560
!listconcat(RVA22S64Features,
561561
[FeatureStdExtV,
562562
FeatureStdExtSscofpmf,
@@ -581,7 +581,7 @@ def SPACEMIT_X60 : RISCVProcessorModel<"spacemit-x60",
581581
}
582582

583583
def RP2350_HAZARD3 : RISCVProcessorModel<"rp2350-hazard3",
584-
GenericModel,
584+
NoSchedModel,
585585
[Feature32Bit,
586586
FeatureStdExtI,
587587
FeatureStdExtM,

llvm/lib/Target/RISCV/RISCVSchedGeneric.td

Lines changed: 0 additions & 18 deletions
This file was deleted.

llvm/test/CodeGen/RISCV/GlobalISel/add-imm.ll

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -212,30 +212,30 @@ define i64 @add64_accept(i64 %a) nounwind {
212212
define void @add32_reject() nounwind {
213213
; RV32I-LABEL: add32_reject:
214214
; RV32I: # %bb.0:
215-
; RV32I-NEXT: lui a0, 1
216-
; RV32I-NEXT: lui a1, %hi(ga)
217-
; RV32I-NEXT: lui a2, %hi(gb)
218-
; RV32I-NEXT: lw a3, %lo(ga)(a1)
219-
; RV32I-NEXT: lw a4, %lo(gb)(a2)
220-
; RV32I-NEXT: addi a0, a0, -1096
221-
; RV32I-NEXT: add a3, a3, a0
222-
; RV32I-NEXT: add a0, a4, a0
223-
; RV32I-NEXT: sw a3, %lo(ga)(a1)
224-
; RV32I-NEXT: sw a0, %lo(gb)(a2)
215+
; RV32I-NEXT: lui a0, %hi(ga)
216+
; RV32I-NEXT: lui a1, %hi(gb)
217+
; RV32I-NEXT: lw a2, %lo(ga)(a0)
218+
; RV32I-NEXT: lw a3, %lo(gb)(a1)
219+
; RV32I-NEXT: lui a4, 1
220+
; RV32I-NEXT: addi a4, a4, -1096
221+
; RV32I-NEXT: add a2, a2, a4
222+
; RV32I-NEXT: add a3, a3, a4
223+
; RV32I-NEXT: sw a2, %lo(ga)(a0)
224+
; RV32I-NEXT: sw a3, %lo(gb)(a1)
225225
; RV32I-NEXT: ret
226226
;
227227
; RV64I-LABEL: add32_reject:
228228
; RV64I: # %bb.0:
229-
; RV64I-NEXT: lui a0, 1
230-
; RV64I-NEXT: lui a1, %hi(ga)
231-
; RV64I-NEXT: lui a2, %hi(gb)
232-
; RV64I-NEXT: lw a3, %lo(ga)(a1)
233-
; RV64I-NEXT: lw a4, %lo(gb)(a2)
234-
; RV64I-NEXT: addi a0, a0, -1096
235-
; RV64I-NEXT: add a3, a3, a0
236-
; RV64I-NEXT: add a0, a4, a0
237-
; RV64I-NEXT: sw a3, %lo(ga)(a1)
238-
; RV64I-NEXT: sw a0, %lo(gb)(a2)
229+
; RV64I-NEXT: lui a0, %hi(ga)
230+
; RV64I-NEXT: lui a1, %hi(gb)
231+
; RV64I-NEXT: lw a2, %lo(ga)(a0)
232+
; RV64I-NEXT: lw a3, %lo(gb)(a1)
233+
; RV64I-NEXT: lui a4, 1
234+
; RV64I-NEXT: addi a4, a4, -1096
235+
; RV64I-NEXT: add a2, a2, a4
236+
; RV64I-NEXT: add a3, a3, a4
237+
; RV64I-NEXT: sw a2, %lo(ga)(a0)
238+
; RV64I-NEXT: sw a3, %lo(gb)(a1)
239239
; RV64I-NEXT: ret
240240
%1 = load i32, ptr @ga, align 4
241241
%2 = load i32, ptr @gb, align 4

0 commit comments

Comments
 (0)