fixup! [clang-tidy] Added check to detect redundant inline keyword

Removed unused part of matcher + clang-format

Author: felix642

clang-tools-extra/clang-tidy/readability/RedundantInlineSpecifierCheck.cpp

@@ -24,31 +24,31 @@ using namespace clang::ast_matchers;
 
 namespace clang::tidy::readability {
 
-AST_POLYMORPHIC_MATCHER(isInlineSpecified, AST_POLYMORPHIC_SUPPORTED_TYPES(
-                                                      FunctionDecl,
-                                                                  VarDecl)) {
+AST_POLYMORPHIC_MATCHER(isInlineSpecified,
+                        AST_POLYMORPHIC_SUPPORTED_TYPES(FunctionDecl,
+                                                        VarDecl)) {
   if (const auto *FD = dyn_cast<FunctionDecl>(&Node))
     return FD->isInlineSpecified();
   if (const auto *VD = dyn_cast<VarDecl>(&Node))
     return VD->isInlineSpecified();
   llvm_unreachable("Not a valid polymorphic type");
 }
 
-
 static std::optional<SourceLocation>
 getInlineTokenLocation(SourceRange RangeLocation, const SourceManager &Sources,
                        const LangOptions &LangOpts) {
   Token FirstToken;
   Lexer::getRawToken(RangeLocation.getBegin(), FirstToken, Sources, LangOpts,
-                             true);
+                     true);
   std::optional<Token> CurrentToken = FirstToken;
   while (CurrentToken && CurrentToken->getLocation() < RangeLocation.getEnd() &&
          CurrentToken->isNot(tok::eof)) {
     if (CurrentToken->is(tok::raw_identifier) &&
         CurrentToken->getRawIdentifier() == "inline")
       return CurrentToken->getLocation();
 
-    CurrentToken = Lexer::findNextToken(CurrentToken->getLocation(), Sources, LangOpts);
+    CurrentToken =
+        Lexer::findNextToken(CurrentToken->getLocation(), Sources, LangOpts);
   }
   return std::nullopt;
 }
@@ -58,8 +58,7 @@ void RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
       functionDecl(unless(isExpansionInSystemHeader()),
                    unless(hasAncestor(lambdaExpr())), isInlineSpecified(),
                    anyOf(isConstexpr(), isDeleted(),
-                         allOf(isDefinition(), hasAncestor(recordDecl()),
-                               unless(hasAncestor(cxxConstructorDecl())))))
+                         allOf(isDefinition(), hasAncestor(recordDecl()))))
           .bind("fun_decl"),
       this);
 
@@ -71,16 +70,18 @@ void RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
       this);
 
   Finder->addMatcher(
-      functionTemplateDecl(has(functionDecl(isInlineSpecified()))).bind("templ_decl"),
+      functionTemplateDecl(has(functionDecl(isInlineSpecified())))
+          .bind("templ_decl"),
       this);
 }
 
 template <typename T>
 void RedundantInlineSpecifierCheck::handleMatchedDecl(
     const T *MatchedDecl, const SourceManager &Sources,
     const MatchFinder::MatchResult &Result, StringRef Message) {
-  if (std::optional<SourceLocation> Loc = getInlineTokenLocation(MatchedDecl->getSourceRange(), Sources,
-                                        Result.Context->getLangOpts()))
+  if (std::optional<SourceLocation> Loc =
+          getInlineTokenLocation(MatchedDecl->getSourceRange(), Sources,
+                                 Result.Context->getLangOpts()))
     diag(*Loc, Message) << MatchedDecl << FixItHint::CreateRemoval(*Loc);
 }
 

clang-tools-extra/clang-tidy/readability/RedundantInlineSpecifierCheck.h

@@ -13,7 +13,8 @@
 
 namespace clang::tidy::readability {
 
-/// Detects redundant ``inline`` specifiers on function and variable declarations.
+/// Detects redundant ``inline`` specifiers on function and variable
+/// declarations.
 ///
 /// For the user-facing documentation see:
 /// http://clang.llvm.org/extra/clang-tidy/checks/readability/readability-redundant-inline-specifier.html