Skip to content

Commit 06ad863

Browse files
authored
[NFC] Prefer str.resize(len) over str.substr(0, len) (#91067)
1 parent 87f3407 commit 06ad863

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

llvm/include/llvm/Analysis/DOTGraphTraitsPass.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,12 @@ struct DOTGraphTraitsViewer
8787
};
8888

8989
static inline void shortenFileName(std::string &FN, unsigned char len = 250) {
90-
91-
FN = FN.substr(0, len);
92-
90+
if (FN.length() > len)
91+
FN.resize(len);
9392
auto strLen = FN.length();
9493
while (strLen > 0) {
95-
if (auto it = nameObj.find(FN); it != nameObj.end()) {
96-
FN = FN.substr(0, --len);
94+
if (nameObj.find(FN) != nameObj.end()) {
95+
FN.resize(--len);
9796
} else {
9897
nameObj.insert(FN);
9998
break;

0 commit comments

Comments
 (0)