Skip to content

Commit 08af115

Browse files
authored
Fix mistakes in #113532 (#115631)
Found during review #115151
1 parent 38b0e1c commit 08af115

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

llvm/lib/Target/X86/X86ISelLowering.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27328,8 +27328,6 @@ static SDValue LowerINTRINSIC_W_CHAIN(SDValue Op, const X86Subtarget &Subtarget,
2732827328
case Intrinsic::x86_t2rpntlvwz0t1_internal:
2732927329
case Intrinsic::x86_t2rpntlvwz1_internal:
2733027330
case Intrinsic::x86_t2rpntlvwz1t1_internal: {
27331-
if (!Subtarget.hasAMXTILE())
27332-
break;
2733327331
auto *X86MFI = DAG.getMachineFunction().getInfo<X86MachineFunctionInfo>();
2733427332
X86MFI->setAMXProgModel(AMXProgModelEnum::ManagedRA);
2733527333
unsigned IntNo = Op.getConstantOperandVal(1);

llvm/lib/Target/X86/X86InstrInfo.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4737,6 +4737,7 @@ static bool isAMXOpcode(unsigned Opc) {
47374737
case X86::TILELOADD_EVEX:
47384738
case X86::TILESTORED_EVEX:
47394739
case X86::PTILEPAIRLOAD:
4740+
case X86::PTILEPAIRSTORE:
47404741
return true;
47414742
}
47424743
}

llvm/test/CodeGen/X86/amx_transpose_intrinsics.ll

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,18 +80,18 @@ define void @test_amx_spill(i8* %pointer, i8* %base, i64 %stride) #0 {
8080
; CHECK-NEXT: tileloadd (%rsi,%rdx), %tmm0
8181
; CHECK-NEXT: t2rpntlvwz0 (%rsi,%rdx), %tmm4
8282
; CHECK-NEXT: t2rpntlvwz0t1 (%rsi,%rdx), %tmm6
83-
; CHECK-NEXT: tilestored %tmm6, {{[-0-9]+}}(%r{{[sb]}}p) # 1024-byte Folded Spill
84-
; CHECK-NEXT: tilestored %tmm7, {{[-0-9]+}}(%r{{[sb]}}p) # 1024-byte Folded Spill
83+
; CHECK-NEXT: movabsq $64, %rcx
84+
; CHECK-NEXT: tilestored %tmm6, 4032(%rsp,%rcx) # 1024-byte Folded Spill
85+
; CHECK-NEXT: tilestored %tmm7, 5056(%rsp,%rcx) # 1024-byte Folded Spill
8586
; CHECK-NEXT: t2rpntlvwz1 (%rsi,%rdx), %tmm6
86-
; CHECK-NEXT: tilestored %tmm6, {{[-0-9]+}}(%r{{[sb]}}p) # 1024-byte Folded Spill
87-
; CHECK-NEXT: tilestored %tmm7, {{[-0-9]+}}(%r{{[sb]}}p) # 1024-byte Folded Spill
87+
; CHECK-NEXT: tilestored %tmm6, 1984(%rsp,%rcx) # 1024-byte Folded Spill
88+
; CHECK-NEXT: tilestored %tmm7, 3008(%rsp,%rcx) # 1024-byte Folded Spill
8889
; CHECK-NEXT: t2rpntlvwz1t1 (%rsi,%rdx), %tmm6
89-
; CHECK-NEXT: tilestored %tmm6, {{[-0-9]+}}(%r{{[sb]}}p) # 1024-byte Folded Spill
90-
; CHECK-NEXT: tilestored %tmm7, {{[-0-9]+}}(%r{{[sb]}}p) # 1024-byte Folded Spill
90+
; CHECK-NEXT: tilestored %tmm6, -64(%rsp,%rcx) # 1024-byte Folded Spill
91+
; CHECK-NEXT: tilestored %tmm7, 960(%rsp,%rcx) # 1024-byte Folded Spill
9192
; CHECK-NEXT: t2rpntlvwz0 (%rsi,%rdx), %tmm6
9293
; CHECK-NEXT: tilestored %tmm4, (%rsi,%rdx)
9394
; CHECK-NEXT: tilestored %tmm5, (%rsi,%rdx)
94-
; CHECK-NEXT: movabsq $64, %rcx
9595
; CHECK-NEXT: tileloadd 4032(%rsp,%rcx), %tmm4 # 1024-byte Folded Reload
9696
; CHECK-NEXT: tileloadd 5056(%rsp,%rcx), %tmm5 # 1024-byte Folded Reload
9797
; CHECK-NEXT: tilestored %tmm4, (%rsi,%rdx)

0 commit comments

Comments
 (0)