Skip to content

Commit 08dd645

Browse files
authored
[RISC-V] Bad immediate value for Zcmp instructions with E extension (#84925)
When we are using the Zcmp extension together with the E extension in 32-bit mode and we need to spill both callee-saved registers as well as needing a couple of 32-bit stack slots, we emit a meaningless stack adjustment with cm.push/cm.popret. Furthermore this leads to the stack slot for the ra being clobbered so control returns to a random location. This is just a pre-commit test so that the PR for the fix shows the difference in code generation.
1 parent beba307 commit 08dd645

File tree

1 file changed

+49
-0
lines changed

1 file changed

+49
-0
lines changed
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
2+
; RUN: llc -mtriple=riscv32 -mattr=+zcmp,+e -target-abi ilp32e -verify-machineinstrs < %s | FileCheck %s --check-prefix=RV32
3+
define ptr @func(ptr %s, i32 %_c, ptr %incdec.ptr, i1 %0, i8 %conv14) #0 {
4+
; RV32-LABEL: func:
5+
; RV32: # %bb.0: # %entry
6+
; RV32-NEXT: cm.push {ra, s0-s1}, -24
7+
; RV32-NEXT: .cfi_def_cfa_offset 24
8+
; RV32-NEXT: .cfi_offset ra, -12
9+
; RV32-NEXT: .cfi_offset s0, -8
10+
; RV32-NEXT: .cfi_offset s1, -4
11+
; RV32-NEXT: sw a4, 4(sp) # 4-byte Folded Spill
12+
; RV32-NEXT: sw a2, 0(sp) # 4-byte Folded Spill
13+
; RV32-NEXT: mv a2, a1
14+
; RV32-NEXT: mv s1, a0
15+
; RV32-NEXT: li a0, 1
16+
; RV32-NEXT: andi a3, a3, 1
17+
; RV32-NEXT: .LBB0_1: # %while.body
18+
; RV32-NEXT: # =>This Inner Loop Header: Depth=1
19+
; RV32-NEXT: mv s0, a0
20+
; RV32-NEXT: li a0, 0
21+
; RV32-NEXT: bnez a3, .LBB0_1
22+
; RV32-NEXT: # %bb.2: # %while.end
23+
; RV32-NEXT: lui a0, 4112
24+
; RV32-NEXT: addi a1, a0, 257
25+
; RV32-NEXT: mv a0, a2
26+
; RV32-NEXT: call __mulsi3
27+
; RV32-NEXT: sw a0, 0(zero)
28+
; RV32-NEXT: andi s0, s0, 1
29+
; RV32-NEXT: lw a0, 0(sp) # 4-byte Folded Reload
30+
; RV32-NEXT: add s0, s0, a0
31+
; RV32-NEXT: lw a0, 4(sp) # 4-byte Folded Reload
32+
; RV32-NEXT: sb a0, 0(s0)
33+
; RV32-NEXT: mv a0, s1
34+
; RV32-NEXT: cm.popret {ra, s0-s1}, 24
35+
entry:
36+
br label %while.body
37+
38+
while.body: ; preds = %while.body, %entry
39+
%n.addr.042 = phi i32 [ 1, %entry ], [ 0, %while.body ]
40+
br i1 %0, label %while.body, label %while.end
41+
42+
while.end: ; preds = %while.body
43+
%or5 = mul i32 %_c, 16843009
44+
store i32 %or5, ptr null, align 4
45+
%1 = and i32 %n.addr.042, 1
46+
%scevgep = getelementptr i8, ptr %incdec.ptr, i32 %1
47+
store i8 %conv14, ptr %scevgep, align 1
48+
ret ptr %s
49+
}

0 commit comments

Comments
 (0)