Skip to content

Commit 0a5b101

Browse files
committed
[libc++] Update the status for lwg-3120
Current implementation already have struct __initial_descriptor which saves the initial state. When release() called, we will reset ptr __initial_descriptor.__cur_, next buffer size never changed. This patch update the lwg 3120 issue latest status and add test.
1 parent de12bf5 commit 0a5b101

File tree

2 files changed

+47
-1
lines changed

2 files changed

+47
-1
lines changed

libcxx/docs/Status/Cxx23Issues.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"`LWG2731 <https://wg21.link/LWG2731>`__","Existence of ``lock_guard<MutexTypes...>::mutex_type`` typedef unclear","2020-11 (Virtual)","|Complete|","5",""
1515
"`LWG2743 <https://wg21.link/LWG2743>`__","P0083R3 ``node_handle`` private members missing ""exposition only"" comment","2020-11 (Virtual)","|Nothing To Do|","",""
1616
"`LWG2820 <https://wg21.link/LWG2820>`__","Clarify ``<cstdint>`` macros","2020-11 (Virtual)","|Nothing To Do|","",""
17-
"`LWG3120 <https://wg21.link/LWG3120>`__","Unclear behavior of ``monotonic_buffer_resource::release()``","2020-11 (Virtual)","","",""
17+
"`LWG3120 <https://wg21.link/LWG3120>`__","Unclear behavior of ``monotonic_buffer_resource::release()``","2020-11 (Virtual)","|Complete|","16",""
1818
"`LWG3170 <https://wg21.link/LWG3170>`__","``is_always_equal`` added to ``std::allocator`` makes the standard library treat derived types as always equal","2020-11 (Virtual)","|Complete|","18",""
1919
"`LWG3036 <https://wg21.link/LWG3036>`__","``polymorphic_allocator::destroy`` is extraneous","2020-11 (Virtual)","|Nothing To Do|","","Reverted by P2875R4"
2020
"`LWG3171 <https://wg21.link/LWG3171>`__","LWG2989 breaks ``directory_entry`` stream insertion","2020-11 (Virtual)","|Complete|","14",""
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
//===----------------------------------------------------------------------===//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6+
//
7+
//===----------------------------------------------------------------------===//
8+
9+
// REQUIRES: std-at-least-c++17
10+
// UNSUPPORTED: availability-pmr-missing
11+
12+
// <memory_resource>
13+
14+
// class monotonic_buffer_resource
15+
16+
#include <memory_resource>
17+
#include <cassert>
18+
19+
#include "count_new.h"
20+
#include "test_macros.h"
21+
22+
int main(int, char**) {
23+
{
24+
{
25+
// when init given a next buffer size, after release(), reset/not change next buffer size from initial state
26+
constexpr size_t expect_next_buffer_size = 512;
27+
std::pmr::monotonic_buffer_resource mr{nullptr, expect_next_buffer_size, std::pmr::new_delete_resource()};
28+
29+
(void)mr.allocate(1);
30+
mr.release();
31+
ASSERT_WITH_LIBRARY_INTERNAL_ALLOCATIONS(globalMemCounter.checkLastNewSizeGe(expect_next_buffer_size));
32+
}
33+
{
34+
// when init given a buffer, allocate some memory from buffer. after release(), offset of the buffer should be 0
35+
constexpr size_t buffer_size = 512;
36+
char buffer[buffer_size];
37+
std::pmr::monotonic_buffer_resource mr{buffer, buffer_size, std::pmr::null_memory_resource()};
38+
39+
auto expect_mem_start = mr.allocate(1);
40+
mr.release();
41+
auto ths_mem_start = mr.allocate(1);
42+
assert(expect_mem_start == ths_mem_start);
43+
}
44+
}
45+
return 0;
46+
}

0 commit comments

Comments
 (0)