Skip to content

Commit 0a73e1e

Browse files
committed
[analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc
Reviewed By: steakhal Differential Revision: https://reviews.llvm.org/D159397
1 parent 1362206 commit 0a73e1e

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1141,22 +1141,28 @@ MallocChecker::performKernelMalloc(const CallEvent &Call, CheckerContext &C,
11411141
llvm::Triple::OSType OS = Ctx.getTargetInfo().getTriple().getOS();
11421142

11431143
if (!KernelZeroFlagVal) {
1144-
if (OS == llvm::Triple::FreeBSD)
1144+
switch (OS) {
1145+
case llvm::Triple::FreeBSD:
11451146
KernelZeroFlagVal = 0x0100;
1146-
else if (OS == llvm::Triple::NetBSD)
1147+
break;
1148+
case llvm::Triple::NetBSD:
11471149
KernelZeroFlagVal = 0x0002;
1148-
else if (OS == llvm::Triple::OpenBSD)
1150+
break;
1151+
case llvm::Triple::OpenBSD:
11491152
KernelZeroFlagVal = 0x0008;
1150-
else if (OS == llvm::Triple::Linux)
1153+
break;
1154+
case llvm::Triple::Linux:
11511155
// __GFP_ZERO
11521156
KernelZeroFlagVal = 0x8000;
1153-
else
1157+
break;
1158+
default:
11541159
// FIXME: We need a more general way of getting the M_ZERO value.
11551160
// See also: O_CREAT in UnixAPIChecker.cpp.
11561161

11571162
// Fall back to normal malloc behavior on platforms where we don't
11581163
// know M_ZERO.
11591164
return std::nullopt;
1165+
}
11601166
}
11611167

11621168
// We treat the last argument as the flags argument, and callers fall-back to

0 commit comments

Comments
 (0)