improve

Author: chelini

mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp

@@ -2535,8 +2535,11 @@ transform::TileOp::apply(transform::TransformRewriter &rewriter,
       return diag;
     }
     if (tileSizes.size() > tilingInterface.getLoopIteratorTypes().size()) {
-      DiagnosedSilenceableFailure diag = emitSilenceableError()
-                                         << "too many tiles for";
+      DiagnosedSilenceableFailure diag =
+          emitSilenceableError()
+          << "too many tiles provided, expected at most "
+          << tilingInterface.getLoopIteratorTypes().size() << " found "
+          << tileSizes.size();
       diag.attachNote(op->getLoc()) << "target op";
       return diag;
     }

mlir/test/Dialect/Linalg/transform-op-tile.mlir

@@ -223,8 +223,8 @@ transform.sequence failures(propagate) {
 
 // -----
 
-func.func @matmul(%arg0: tensor<128x128xf32>, %arg1: tensor<128x128xf32>,
-                    %arg2: tensor<128x128xf32>) ->  tensor<128x128xf32> {
+func.func @too_many_tiles(%arg0: tensor<128x128xf32>, %arg1: tensor<128x128xf32>,
+                          %arg2: tensor<128x128xf32>) ->  tensor<128x128xf32> {
   // expected-note @below {{target op}}
   %0 = linalg.matmul ins(%arg0, %arg1: tensor<128x128xf32>, tensor<128x128xf32>)
                      outs(%arg2: tensor<128x128xf32>) -> tensor<128x128xf32>
@@ -234,6 +234,6 @@ func.func @matmul(%arg0: tensor<128x128xf32>, %arg1: tensor<128x128xf32>,
 transform.sequence failures(propagate) {
 ^bb0(%arg1: !transform.any_op):
   %0 = transform.structured.match ops{["linalg.matmul"]} in %arg1 : (!transform.any_op) -> !transform.any_op
-  // expected-error @below {{too many tiles for}}
+  // expected-error @below {{too many tiles provided, expected at most 3 found 4}}
   %1, %loops = transform.structured.tile %0 [1, 0, 0, 0] : (!transform.any_op) -> (!transform.any_op, !transform.any_op)
 }