Skip to content

Commit 0b1c8fd

Browse files
committed
[lldb][ClangExpressionParser] Remove duplicate construction of ExternalASTSourceWrapper
This is an oversight from #104817 where the intention was to hoist the ExternalASTSourceWrapper construction out of the conditional so it can be set on both the `SemaSourceWithPriorities` and be added as an external source to Sema. But the inner `ExternalASTSourceWrapper` allocation wasn't actually removed. This currently all works fine because all these AST sources are refcounted and point to the same underlying AST sources. But this patch cleans this up regardless.
1 parent 91e09c3 commit 0b1c8fd

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1229,8 +1229,6 @@ ClangExpressionParser::ParseInternal(DiagnosticManager &diagnostic_manager,
12291229
auto *module_wrapper =
12301230
new ExternalASTSourceWrapper(ast_context.getExternalSource());
12311231

1232-
auto *ast_source_wrapper = new ExternalASTSourceWrapper(ast_source);
1233-
12341232
auto *multiplexer =
12351233
new SemaSourceWithPriorities(module_wrapper, ast_source_wrapper);
12361234

0 commit comments

Comments
 (0)