Address review comments

Author: marbre

mlir/include/mlir/Conversion/ArithToEmitC/ArithToEmitC.h

@@ -11,8 +11,10 @@
 
 namespace mlir {
 class RewritePatternSet;
+class TypeConverter;
 
-void populateArithToEmitCPatterns(RewritePatternSet &patterns);
+void populateArithToEmitCPatterns(TypeConverter typeConverter,
+                                  RewritePatternSet &patterns);
 } // namespace mlir
 
 #endif // MLIR_CONVERSION_ARITHTOEMITC_ARITHTOEMITC_H

mlir/include/mlir/Conversion/Passes.td

@@ -137,7 +137,7 @@ def ArithToAMDGPUConversionPass : Pass<"convert-arith-to-amdgpu"> {
 // ArithToEmitC
 //===----------------------------------------------------------------------===//
 
-def ConvertArithToEmitC : Pass<"convert-arith-to-emitc", "ModuleOp"> {
+def ConvertArithToEmitC : Pass<"convert-arith-to-emitc"> {
   let summary = "Convert Arith dialect to EmitC dialect";
   let dependentDialects = ["emitc::EmitCDialect"];
 }

mlir/lib/Conversion/ArithToEmitC/ArithToEmitC.cpp

@@ -45,7 +45,8 @@ class ArithOpConversion final : public OpConversionPattern<ArithOp> {
 // Pattern population
 //===----------------------------------------------------------------------===//
 
-void mlir::populateArithToEmitCPatterns(RewritePatternSet &patterns) {
+void mlir::populateArithToEmitCPatterns(TypeConverter typeConverter,
+                                        RewritePatternSet &patterns) {
   MLIRContext *ctx = patterns.getContext();
 
   // clang-format off

mlir/lib/Conversion/ArithToEmitC/ArithToEmitCPass.cpp

@@ -39,7 +39,9 @@ void ConvertArithToEmitC::runOnOperation() {
   target.addLegalDialect<emitc::EmitCDialect>();
 
   RewritePatternSet patterns(&getContext());
-  populateArithToEmitCPatterns(patterns);
+  TypeConverter typeConverter;
+
+  populateArithToEmitCPatterns(typeConverter, patterns);
 
   if (failed(
           applyPartialConversion(getOperation(), target, std::move(patterns))))