Skip to content

Commit 0b66267

Browse files
removing unused rowshare related changes
Signed-off-by: Muzammiluddin Syed <[email protected]>
1 parent b813731 commit 0b66267

File tree

4 files changed

+2
-32
lines changed

4 files changed

+2
-32
lines changed

mlir/include/mlir/Dialect/AMDGPU/IR/AMDGPU.td

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -524,8 +524,7 @@ def AMDGPU_DPPPerm : I32EnumAttr<"DPPPerm",
524524
I32EnumAttrCase<"row_mirror", 8>,
525525
I32EnumAttrCase<"row_half_mirror", 9>,
526526
I32EnumAttrCase<"row_bcast_15", 10>,
527-
I32EnumAttrCase<"row_bcast_31", 11>,
528-
I32EnumAttrCase<"row_share", 12>
527+
I32EnumAttrCase<"row_bcast_31", 11>
529528
]> {
530529
let genSpecializedAttr = 0;
531530
let cppNamespace = "::mlir::amdgpu";
@@ -558,7 +557,6 @@ def AMDGPU_DPPOp : AMDGPU_Op<"dpp", [SameTypeOperands, AllTypesMatch<["result",
558557
- Reverse within a half-row (`row_half_mirror`)
559558
- Broadcast the 15th lane of each row to the next row (`row_bcast`)
560559
- Broadcast lane 31 to rows 2 and 3 (`row_bcast`)
561-
- Broadcast a lane [0-15] within row 0 to all lanes of row 0 (`row_share`)
562560
}];
563561
let results = (outs AnyType:$result);
564562
let assemblyFormat = [{

mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,8 +1292,7 @@ struct AMDGPUDPPLowering : public ConvertOpToLLVMPattern<DPPOp> {
12921292
ROW_MIRROR = 0x140,
12931293
ROW_HALF_MIRROR = 0x141,
12941294
BCAST15 = 0x142,
1295-
BCAST31 = 0x143,
1296-
ROW_SHARE0 = 0x150
1295+
BCAST31 = 0x143
12971296
};
12981297

12991298
auto kind = DppOp.getKind();
@@ -1351,11 +1350,6 @@ struct AMDGPUDPPLowering : public ConvertOpToLLVMPattern<DPPOp> {
13511350
case DPPPerm::row_bcast_31:
13521351
DppCtrl = DppCtrl::BCAST31;
13531352
break;
1354-
case DPPPerm::row_share:
1355-
if (auto intAttr = cast<IntegerAttr>(*permArgument)) {
1356-
DppCtrl = intAttr.getInt() + DppCtrl::ROW_SHARE0;
1357-
}
1358-
break;
13591353
}
13601354

13611355
// Check for row_mask, bank_mask, bound_ctrl if they exist and create

mlir/lib/Dialect/AMDGPU/IR/AMDGPUDialect.cpp

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -468,20 +468,6 @@ LogicalResult DPPOp::verify() {
468468
}
469469
break;
470470
}
471-
472-
case DPPPerm::row_share: {
473-
if (!permArgument) {
474-
return emitOpError("Attribute '" + Twine(stringifyDPPPerm(kind)) +
475-
"' value not specified");
476-
}
477-
if (auto intAttr = dyn_cast<IntegerAttr>(permArgument)) {
478-
uint32_t attrValue = intAttr.getInt();
479-
if (attrValue < 0 || attrValue > 15) {
480-
return emitOpError(
481-
"Attribute value for 'row_share' must be between 0 and 15");
482-
}
483-
}
484-
} break;
485471
}
486472
return success();
487473
}

mlir/test/Conversion/AMDGPUToROCDL/dpp.mlir

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,3 @@ func.func @row_bcast_update_dpp_f16(%arg0: f16, %arg1: f16) -> f16 {
137137
%0 = amdgpu.dpp %arg0 %arg1 row_bcast_15 { bound_ctrl = true } : f16
138138
return %0 : f16
139139
}
140-
141-
func.func @dpp_row_share(%arg0: i32, %arg1: i32) -> i32 {
142-
// CHECK-LABEL: func @dpp_row_share
143-
// CHECK: rocdl.update.dpp %arg0, %arg1 with 351, 15, 15, false : i32
144-
// CHECK: return %0 : i32
145-
%0 = amdgpu.dpp %arg0 %arg1 row_share ( 0xf : i32 ) : i32
146-
return %0 : i32
147-
}

0 commit comments

Comments
 (0)