[lldb] Re-enable VSCode tests

The VSCode tests were all disabled on macOS because the implementation
had some issues that resulted in flakiness on Darwin. It seems most of
these issues have been addressed. I've re-enabled all the tests that
consistently passed locally.

Author: JDevlieghere

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py

@@ -46,7 +46,6 @@ def set_and_hit_breakpoint(self, continueToExit=True):
 
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @skipIfNetBSD # Hangs on NetBSD as well
     @no_debug_info_test
     def test_by_pid(self):
@@ -63,7 +62,6 @@ def test_by_pid(self):
         self.set_and_hit_breakpoint(continueToExit=True)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @skipIfNetBSD # Hangs on NetBSD as well
     @no_debug_info_test
     def test_by_name(self):
@@ -99,7 +97,7 @@ def cleanup():
         self.set_and_hit_breakpoint(continueToExit=True)
 
     @skipUnlessDarwin
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfDarwin
     @skipIfNetBSD # Hangs on NetBSD as well
     @no_debug_info_test
     def test_by_name_waitFor(self):
@@ -117,7 +115,7 @@ def test_by_name_waitFor(self):
         self.set_and_hit_breakpoint(continueToExit=True)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfDarwin
     @skipIfNetBSD # Hangs on NetBSD as well
     @no_debug_info_test
     def test_commands(self):

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py

@@ -18,7 +18,6 @@ class TestVSCode_setBreakpoints(lldbvscode_testcase.VSCodeTestCaseBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_set_and_clear(self):
         '''Tests setting and clearing source file and line breakpoints.
@@ -151,7 +150,6 @@ def test_set_and_clear(self):
                                 "expect breakpoint still verified")
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_functionality(self):
         '''Tests hitting breakpoints and the functionality of a single

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py

@@ -18,7 +18,6 @@ class TestVSCode_setExceptionBreakpoints(
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @expectedFailureNetBSD
     @no_debug_info_test
     def test_functionality(self):

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py

@@ -18,7 +18,6 @@ class TestVSCode_setFunctionBreakpoints(
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_set_and_clear(self):
         '''Tests setting and clearing function breakpoints.
@@ -110,7 +109,6 @@ def test_set_and_clear(self):
                             "expect %u source breakpoints" % (len(functions)))
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_functionality(self):
         '''Tests hitting breakpoints and the functionality of a single

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py

@@ -18,7 +18,7 @@ class TestVSCode_launch(lldbvscode_testcase.VSCodeTestCaseBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
+    @skipIfDarwin # Flaky
     @no_debug_info_test
     def test_default(self):
         '''
@@ -37,7 +37,6 @@ def test_default(self):
                         "make sure program path is in first argument")
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_stopOnEntry(self):
         '''
@@ -58,7 +57,6 @@ def test_stopOnEntry(self):
                         'verify stop isn\'t "main" breakpoint')
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_cwd(self):
         '''
@@ -87,7 +85,6 @@ def test_cwd(self):
         self.assertTrue(found, "verified program working directory")
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_debuggerRoot(self):
         '''
@@ -117,7 +114,6 @@ def test_debuggerRoot(self):
         self.continue_to_exit()
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_sourcePath(self):
         '''
@@ -144,7 +140,6 @@ def test_sourcePath(self):
         self.continue_to_exit()
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_disableSTDIO(self):
         '''
@@ -160,7 +155,6 @@ def test_disableSTDIO(self):
                         "expect no program output")
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @skipIfLinux # shell argument expansion doesn't seem to work on Linux
     @expectedFailureNetBSD
     @no_debug_info_test
@@ -187,7 +181,6 @@ def test_shellExpandArguments_enabled(self):
                                     glob, program))
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_shellExpandArguments_disabled(self):
         '''
@@ -214,7 +207,6 @@ def test_shellExpandArguments_disabled(self):
                                     glob, glob))
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_args(self):
         '''
@@ -241,7 +233,6 @@ def test_args(self):
                             'arg[%i] "%s" not in "%s"' % (i+1, quoted_arg, lines[i]))
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_environment(self):
         '''
@@ -275,7 +266,6 @@ def test_environment(self):
                                 var, lines))
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_commands(self):
         '''
@@ -343,7 +333,6 @@ def test_commands(self):
         self.verify_commands('exitCommands', output, exitCommands)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_extra_launch_commands(self):
         '''

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py

@@ -53,7 +53,6 @@ def verify_stackFrame(self, frame_idx, stackFrame):
                                                      expected_line))
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_stackTrace(self):
         '''

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py

@@ -17,7 +17,6 @@ class TestVSCode_step(lldbvscode_testcase.VSCodeTestCaseBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_step(self):
         '''

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py

@@ -74,7 +74,6 @@ def verify_variables(self, verify_dict, variables, varref_dict=None):
             self.verify_values(verify_dict[name], variable, varref_dict)
 
     @skipIfWindows
-    @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
     @no_debug_info_test
     def test_scopes_variables_setVariable_evaluate(self):
         '''