Skip to content

Commit 0d9d5f7

Browse files
authored
[CodeGen] Guard copy propagation in machine CSE against undefs (#97413)
1 parent ecd2bf7 commit 0d9d5f7

File tree

2 files changed

+23
-1
lines changed

2 files changed

+23
-1
lines changed

llvm/lib/CodeGen/MachineCSE.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ bool MachineCSE::PerformTrivialCopyPropagation(MachineInstr *MI,
184184
continue;
185185
bool OnlyOneUse = MRI->hasOneNonDBGUse(Reg);
186186
MachineInstr *DefMI = MRI->getVRegDef(Reg);
187-
if (!DefMI->isCopy())
187+
if (!DefMI || !DefMI->isCopy())
188188
continue;
189189
Register SrcReg = DefMI->getOperand(1).getReg();
190190
if (!SrcReg.isVirtual())
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5
2+
# RUN: llc -mtriple=amdgcn -run-pass=machine-cse -verify-machineinstrs -o - %s | FileCheck %s
3+
4+
# Test to ensure that this does not crash on undefs
5+
---
6+
name: copyprop_regsequence_with_undef
7+
tracksRegLiveness: true
8+
body: |
9+
bb.0:
10+
; CHECK-LABEL: name: copyprop_regsequence_with_undef
11+
; CHECK: [[DEF:%[0-9]+]]:sreg_32 = IMPLICIT_DEF
12+
; CHECK-NEXT: [[DEF1:%[0-9]+]]:sreg_32 = IMPLICIT_DEF
13+
; CHECK-NEXT: [[REG_SEQUENCE:%[0-9]+]]:sreg_64 = REG_SEQUENCE undef %3:sreg_32, %subreg.sub0, [[DEF]], %subreg.sub1
14+
; CHECK-NEXT: [[REG_SEQUENCE1:%[0-9]+]]:sreg_64 = REG_SEQUENCE undef %5:sreg_32, %subreg.sub0, [[DEF1]], %subreg.sub1
15+
; CHECK-NEXT: [[S_ADD_I32_:%[0-9]+]]:sreg_32 = S_ADD_I32 [[REG_SEQUENCE]].sub1, [[REG_SEQUENCE1]].sub1, implicit-def $scc
16+
%0:sreg_32 = IMPLICIT_DEF
17+
%1:sreg_32 = IMPLICIT_DEF
18+
%4:sreg_64 = REG_SEQUENCE undef %10:sreg_32, %subreg.sub0, %0:sreg_32, %subreg.sub1
19+
%5:sreg_64 = REG_SEQUENCE undef %11:sreg_32, %subreg.sub0, %1:sreg_32, %subreg.sub1
20+
%6:sreg_32 = S_ADD_I32 %4.sub1:sreg_64, %5.sub1:sreg_64, implicit-def $scc
21+
22+
...

0 commit comments

Comments
 (0)