Skip to content

Commit 0ef7b1d

Browse files
authored
[scudo] Update secondary cache released pages bound. (#106466)
`MaxReleasedCachePages` has been set to 4. Initially, in #105009 , we set `MaxReleasedCachePages` to 0 so that the partial chunk heuristic could be introduced incrementally as we observed its impact on retrieval order and more generally, performance. Co-authored-by: Joshua Baehring <[email protected]>
1 parent cbb5f03 commit 0ef7b1d

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

compiler-rt/lib/scudo/standalone/secondary.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ struct CachedBlock {
7979
// it suggests that beyond 4 pages, the release execution time is
8080
// longer than the map execution time. In this way, the default
8181
// is dependent on the platform.
82-
// TODO: set MaxReleasedCachePages back to 4U
83-
static constexpr uptr MaxReleasedCachePages = 0U;
82+
static constexpr uptr MaxReleasedCachePages = 4U;
8483

8584
uptr CommitBase = 0;
8685
uptr CommitSize = 0;

0 commit comments

Comments
 (0)