Skip to content

Commit 10d720b

Browse files
[DeadStoreElimination] Add test for recent worklist revision (NFC)
As d5c89cc proved not to be NFC, prior to this change, duplicate `MemoryAccess` entries were being added to the worklist in `isWriteAtEndOfFunction`, prematurely reaching the exploration limit. When `MemorySSAScanLimit` cutoff is set to 4, the store was previously not eliminated. Introduce a regression test for additional validation. The test is a simplified variant of function `ntlmssp_create_session_key`, coming from @dtcxzyw/llvm-opt-benchmark, bench/wireshark/original/packet-ntlmssp.c.ll.
1 parent 6b9ac2a commit 10d720b

File tree

1 file changed

+45
-0
lines changed

1 file changed

+45
-0
lines changed

llvm/test/Transforms/DeadStoreElimination/memoryssa-scan-limit.ll

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
; RUN: opt < %s -passes=dse -dse-memoryssa-scanlimit=0 -S | FileCheck --check-prefix=LIMIT-0 %s
55
; RUN: opt < %s -passes=dse -dse-memoryssa-scanlimit=2 -S | FileCheck --check-prefix=LIMIT-2 %s
66
; RUN: opt < %s -passes=dse -dse-memoryssa-scanlimit=3 -S | FileCheck --check-prefix=LIMIT-3 %s
7+
; RUN: opt < %s -passes=dse -dse-memoryssa-scanlimit=4 -S | FileCheck --check-prefix=LIMIT-4 %s
78

89
target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
910

@@ -71,3 +72,47 @@ bb3:
7172
store i32 0, ptr %P
7273
ret void
7374
}
75+
76+
define void @duplicate_worklist_endoffunction(ptr %ptr.0, ptr %ptr.1) {
77+
; LIMIT-4-LABEL: @duplicate_worklist_endoffunction(
78+
; LIMIT-4-NEXT: entry:
79+
; LIMIT-4-NEXT: [[STACK_0:%.*]] = alloca [768 x i8], align 16
80+
; LIMIT-4-NEXT: [[VAL_0:%.*]] = load i16, ptr [[PTR_1:%.*]], align 8
81+
; LIMIT-4-NEXT: [[COND:%.*]] = icmp ugt i16 [[VAL_0]], 24
82+
; LIMIT-4-NEXT: br i1 [[COND]], label [[BB_1:%.*]], label [[EXIT:%.*]]
83+
; LIMIT-4: bb.1:
84+
; LIMIT-4-NEXT: br label [[LOOP:%.*]]
85+
; LIMIT-4: loop:
86+
; LIMIT-4-NEXT: [[IV:%.*]] = phi i64 [ 0, [[BB_1]] ], [ [[IV_NEXT:%.*]], [[LOOP]] ]
87+
; LIMIT-4-NEXT: [[PTR_3:%.*]] = getelementptr i8, ptr [[STACK_0]], i64 [[IV]]
88+
; LIMIT-4-NEXT: store ptr [[PTR_0:%.*]], ptr [[PTR_3]], align 2
89+
; LIMIT-4-NEXT: [[IV_NEXT]] = add nuw i64 [[IV]], 1
90+
; LIMIT-4-NEXT: [[EXITCOND:%.*]] = icmp eq i64 [[IV_NEXT]], 10
91+
; LIMIT-4-NEXT: br i1 [[EXITCOND]], label [[EXIT]], label [[LOOP]]
92+
; LIMIT-4: exit:
93+
; LIMIT-4-NEXT: ret void
94+
;
95+
entry:
96+
%stack.0 = alloca [768 x i8], align 16
97+
%stack.1 = alloca [20 x i8], align 8
98+
%val.0 = load i16, ptr %ptr.1, align 8
99+
%cond = icmp ugt i16 %val.0, 24
100+
br i1 %cond, label %bb.1, label %exit
101+
102+
bb.1: ; preds = %entry
103+
%ptr.2 = getelementptr inbounds i8, ptr %ptr.1, i64 8
104+
%val.1 = load i64, ptr %ptr.2, align 8
105+
store i64 %val.1, ptr %stack.1, align 8
106+
br label %loop
107+
108+
loop: ; preds = %loop, %bb.1
109+
%iv = phi i64 [ 0, %bb.1 ], [ %iv.next, %loop ]
110+
%ptr.3 = getelementptr i8, ptr %stack.0, i64 %iv
111+
store ptr %ptr.0, ptr %ptr.3, align 2
112+
%iv.next = add nuw i64 %iv, 1
113+
%exitcond = icmp eq i64 %iv.next, 10
114+
br i1 %exitcond, label %exit, label %loop
115+
116+
exit: ; preds = %loop, %entry
117+
ret void
118+
}

0 commit comments

Comments
 (0)