Skip to content

Commit 10f6e33

Browse files
committed
Address nits
1 parent 4006d11 commit 10f6e33

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

llvm/docs/CommandGuide/llvm-objcopy.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ them.
467467
.. option:: --skip-symbol <symbol>
468468

469469
Do not change parameters of symbol <symbol> when executing other options that
470-
can change the symbol's name, binding or visibility
470+
can change the symbol's name, binding or visibility.
471471

472472
.. option:: --skip-symbols <filename>
473473

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ static Error updateAndRemoveSymbols(const CommonConfig &Config,
293293
Obj.SymbolTable->updateSymbols([&](Symbol &Sym) {
294294
if (ELFConfig.SymbolsToSkip.matches(Sym.Name))
295295
return;
296+
296297
// Common and undefined symbols don't make sense as local symbols, and can
297298
// even cause crashes if we localize those, so skip them.
298299
if (!Sym.isCommon() && Sym.getShndx() != SHN_UNDEF &&

0 commit comments

Comments
 (0)