Skip to content

Commit 117d083

Browse files
[JITLink][AArch32] Drop anonymous namespaces around FixupInfo helper classes (NFC)
This fixes various buildbots reporting subobject-linkage warnings after #71649: <class> has a base <name> whose type uses the anonymous namespace
1 parent e00ade1 commit 117d083

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

llvm/include/llvm/ExecutionEngine/JITLink/aarch32.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,10 @@ struct FixupInfoThumb : public FixupInfoBase {
195195
///
196196
template <EdgeKind_aarch32 Kind> struct FixupInfo {};
197197

198-
namespace {
199198
struct FixupInfoArmBranch : public FixupInfoArm {
200199
static constexpr uint32_t Opcode = 0x0a000000;
201200
static constexpr uint32_t ImmMask = 0x00ffffff;
202201
};
203-
} // namespace
204202

205203
template <> struct FixupInfo<Arm_Jump24> : public FixupInfoArmBranch {
206204
static constexpr uint32_t OpcodeMask = 0x0f000000;
@@ -214,13 +212,11 @@ template <> struct FixupInfo<Arm_Call> : public FixupInfoArmBranch {
214212
static constexpr uint32_t BitBlx = 0x10000000;
215213
};
216214

217-
namespace {
218215
struct FixupInfoArmMov : public FixupInfoArm {
219216
static constexpr uint32_t OpcodeMask = 0x0ff00000;
220217
static constexpr uint32_t ImmMask = 0x000f0fff;
221218
static constexpr uint32_t RegMask = 0x0000f000;
222219
};
223-
} // namespace
224220

225221
template <> struct FixupInfo<Arm_MovtAbs> : public FixupInfoArmMov {
226222
static constexpr uint32_t Opcode = 0x03400000;
@@ -244,13 +240,11 @@ template <> struct FixupInfo<Thumb_Call> : public FixupInfoThumb {
244240
static constexpr uint16_t LoBitNoBlx = 0x1000;
245241
};
246242

247-
namespace {
248243
struct FixupInfoThumbMov : public FixupInfoThumb {
249244
static constexpr HalfWords OpcodeMask{0xfbf0, 0x8000};
250245
static constexpr HalfWords ImmMask{0x040f, 0x70ff};
251246
static constexpr HalfWords RegMask{0x0000, 0x0f00};
252247
};
253-
} // namespace
254248

255249
template <> struct FixupInfo<Thumb_MovtAbs> : public FixupInfoThumbMov {
256250
static constexpr HalfWords Opcode{0xf2c0, 0x0000};

0 commit comments

Comments
 (0)