Skip to content

Commit 1345cee

Browse files
fix tests
1 parent 1945945 commit 1345cee

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

libc/test/src/sys/statvfs/linux/fstatvfs_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ struct PathFD {
2828
operator int() const { return fd; }
2929
};
3030

31-
TEST(LlvmLibcSysStatfsTest, FstatfsBasic) {
31+
TEST(LlvmLibcSysStatvfsTest, FstatfsBasic) {
3232
statfs buf[1];
3333
ASSERT_THAT(LIBC_NAMESPACE::fstatfs(PathFD("/"), buf), Succeeds());
3434
ASSERT_THAT(LIBC_NAMESPACE::fstatfs(PathFD("/proc"), buf), Succeeds());
@@ -37,11 +37,11 @@ TEST(LlvmLibcSysStatfsTest, FstatfsBasic) {
3737
ASSERT_EQ(buf->f_type, static_cast<decltype(buf->f_type)>(SYSFS_MAGIC));
3838
}
3939

40-
TEST(LlvmLibcSysStatfsTest, FstatfsNullBuffer) {
40+
TEST(LlvmLibcSysStatvfsTest, FstatvfsNullBuffer) {
4141
ASSERT_THAT(LIBC_NAMESPACE::fstatvfs(PathFD("/"), nullptr), Fails(EFAULT));
4242
}
4343

44-
TEST(LlvmLibcSysStatfsTest, FstatfsInvalidFD) {
44+
TEST(LlvmLibcSysStatvfsTest, FstatvfsInvalidFD) {
4545
statvfs buf[1];
4646
ASSERT_THAT(LIBC_NAMESPACE::fstatvfs(-1, buf), Fails(EBADF));
4747
}

libc/test/src/sys/statvfs/linux/statvfs_test.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,12 @@ TEST(LlvmLibcSysStatfsTest, StatfsBasic) {
2525
ASSERT_EQ(buf->f_type, static_cast<__kernel_long_t>(SYSFS_MAGIC));
2626
}
2727

28+
// POSIX API does not specify what happens when buf is NULL
2829
TEST(LlvmLibcSysStatfsTest, StatfsNullBuffer) {
2930
ASSERT_THAT(LIBC_NAMESPACE::statfs("/", nullptr), Fails(EFAULT));
3031
}
3132

32-
TEST(LlvmLibcSysStatfsTest, InvalidPath) {
33+
TEST(LlvmLibcSysStatfsTest, StatvfsInvalidPath) {
3334
statvfs buf[1];
3435
ASSERT_THAT(LIBC_NAMESPACE::statvfs("", buf), Fails(ENOENT));
3536
ASSERT_THAT(LIBC_NAMESPACE::statvfs("/nonexistent", buf), Fails(ENOENT));
@@ -38,7 +39,7 @@ TEST(LlvmLibcSysStatfsTest, InvalidPath) {
3839
ASSERT_THAT(LIBC_NAMESPACE::statvfs(nullptr, buf), Fails(EFAULT));
3940
}
4041

41-
TEST(LlvmLibcSysStatfsTest, NameTooLong) {
42+
TEST(LlvmLibcSysStatfsTest, StatvfsNameTooLong) {
4243
statvfs buf[1];
4344
ASSERT_THAT(LIBC_NAMESPACE::statvfs("/", buf), Succeeds());
4445
char *name = static_cast<char *>(__builtin_alloca(buf->f_namemax + 3));

0 commit comments

Comments
 (0)