Skip to content

Commit 135531e

Browse files
committed
CRs - remove array changes
1 parent 92fda36 commit 135531e

File tree

2 files changed

+27
-30
lines changed

2 files changed

+27
-30
lines changed

libcxx/include/array

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -270,23 +270,18 @@ struct _LIBCPP_TEMPLATE_VIS array {
270270
template <class _Tp>
271271
struct _LIBCPP_TEMPLATE_VIS array<_Tp, 0> {
272272
// types:
273-
using __self = array;
274-
using value_type = _Tp;
275-
using reference = value_type&;
276-
using const_reference = const value_type&;
277-
using pointer = value_type*;
278-
using const_pointer = const value_type*;
279-
#if defined(_LIBCPP_ABI_USE_WRAP_ITER_IN_STD_ARRAY)
280-
using iterator = __wrap_iter<pointer>;
281-
using const_iterator = __wrap_iter<const_pointer>;
282-
#else
283-
using iterator = pointer;
284-
using const_iterator = const_pointer;
285-
#endif
286-
using size_type = size_t;
287-
using difference_type = ptrdiff_t;
288-
using reverse_iterator = std::reverse_iterator<iterator>;
289-
using const_reverse_iterator = std::reverse_iterator<const_iterator>;
273+
typedef array __self;
274+
typedef _Tp value_type;
275+
typedef value_type& reference;
276+
typedef const value_type& const_reference;
277+
typedef value_type* iterator;
278+
typedef const value_type* const_iterator;
279+
typedef value_type* pointer;
280+
typedef const value_type* const_pointer;
281+
typedef size_t size_type;
282+
typedef ptrdiff_t difference_type;
283+
typedef std::reverse_iterator<iterator> reverse_iterator;
284+
typedef std::reverse_iterator<const_iterator> const_reverse_iterator;
290285

291286
typedef __conditional_t<is_const<_Tp>::value, const __empty, __empty> _EmptyType;
292287

libcxx/test/support/test_iterators.h

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -347,23 +347,25 @@ class contiguous_iterator {
347347
friend class contiguous_iterator;
348348

349349
public:
350-
typedef std::contiguous_iterator_tag iterator_category;
351-
typedef typename std::iterator_traits<It>::value_type value_type;
352-
typedef typename std::iterator_traits<It>::difference_type difference_type;
353-
typedef It pointer;
354-
typedef typename std::iterator_traits<It>::reference reference;
355-
typedef value_type element_type;
350+
using iterator_category = std::contiguous_iterator_tag;
351+
using value_type = typename std::iterator_traits<It>::value_type;
352+
using difference_type = typename std::iterator_traits<It>::difference_type;
353+
using pointer = typename std::iterator_traits<It>::pointer;
354+
using reference = typename std::iterator_traits<It>::reference;
355+
using element_type = value_type;
356356

357-
constexpr It base() const { return it_; }
357+
constexpr It base() const { return it_; }
358358

359-
constexpr contiguous_iterator() : it_() {}
360-
constexpr explicit contiguous_iterator(It it) : it_(it) {}
359+
constexpr contiguous_iterator() : it_() {}
360+
constexpr explicit contiguous_iterator(It it) : it_(it) {}
361361

362-
template <class U>
363-
constexpr contiguous_iterator(const contiguous_iterator<U>& u) : it_(u.it_) {}
362+
template <class U>
363+
constexpr contiguous_iterator(const contiguous_iterator<U>& u) : it_(u.it_) {}
364364

365-
template <class U, class = typename std::enable_if<std::is_default_constructible<U>::value>::type>
366-
constexpr contiguous_iterator(contiguous_iterator<U>&& u) : it_(u.it_) { u.it_ = U(); }
365+
template <class U, class = typename std::enable_if<std::is_default_constructible<U>::value>::type>
366+
constexpr contiguous_iterator(contiguous_iterator<U>&& u) : it_(u.it_) {
367+
u.it_ = U();
368+
}
367369

368370
constexpr reference operator*() const { return *it_; }
369371
constexpr pointer operator->() const { return it_; }

0 commit comments

Comments
 (0)