[clang][Interp][NFC] Use move ctor in moveArrayTy

tbaederr · tbaederr · commit 13faed8737b3 · 2024-08-03T05:44:59.000+02:00
Similar to what we did previously for primitive types, do it for
primitive arrays as well.
diff --git a/clang/lib/AST/Interp/Descriptor.cpp b/clang/lib/AST/Interp/Descriptor.cpp
@@ -76,7 +76,7 @@ static void moveArrayTy(Block *, const std::byte *Src, std::byte *Dst,
   Src += sizeof(InitMapPtr);
   Dst += sizeof(InitMapPtr);
   for (unsigned I = 0, NE = D->getNumElems(); I < NE; ++I) {
-    const auto *SrcPtr = &reinterpret_cast<const T *>(Src)[I];
+    auto *SrcPtr = &reinterpret_cast<T *>(const_cast<std::byte *>(Src))[I];
     auto *DstPtr = &reinterpret_cast<T *>(Dst)[I];
     new (DstPtr) T(std::move(*SrcPtr));
   }

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ static void moveArrayTy(Block , const std::byte Src, std::byte *Dst,`
`76`	`76`	`Src += sizeof(InitMapPtr);`
`77`	`77`	`Dst += sizeof(InitMapPtr);`
`78`	`78`	`for (unsigned I = 0, NE = D->getNumElems(); I < NE; ++I) {`
`79`		`- const auto SrcPtr = &reinterpret_cast<const T >(Src)[I];`
	`79`	`+ auto SrcPtr = &reinterpret_cast<T >(const_cast<std::byte *>(Src))[I];`
`80`	`80`	`auto DstPtr = &reinterpret_cast<T >(Dst)[I];`
`81`	`81`	`new (DstPtr) T(std::move(*SrcPtr));`
`82`	`82`	`}`